search

HxGodot / hxgodot

A Haxe GDExtension for Godot 4
MIT License
232 stars 11 forks source link

Fix quoting for custom extension_api.json #39

Closed jakobwinkler closed 1 year ago

jakobwinkler commented 1 year ago

When passing a custom extension_api.json to the CLI in generate_bindings, the current code would add extra quotes around the supplied path, resulting in something like '"/home/user/extension_api.json"'.

From my tests this seems to work correctly now. Paths with spaces also work. I could only get this to work with absolute paths, but that's better than not at all I guess.

Remember to regenerate the CLI binary (I didn't do that, but I can change the commit if you want me to).

jakobwinkler commented 1 year ago

(originally reported by Frontrider on discord):

HxGodot (1.0.0-alpha)
Generating Godot 4 Haxe bindings...
(unknown) : Uncaught exception Could not read file "/home/frontrider/IdeaProjects/binding/extension_api.json"
src/godot/macros/ClassGenMacros.hx:45: characters 35-66 : Called from here
(unknown) : Called from here