HyQD / coupled-cluster

Upstream coupled cluster code
MIT License
3 stars 3 forks source link

Inconsistent interface to mixing classes #5

Closed Schoyen closed 5 years ago

Schoyen commented 5 years ago

The two mixing classes AlphaMixer and DIIS share the same interface, but the former assumes right hand side solutions with the Fock matrix's diagonal set to zero, whereas the latter assumes the full Fock matrix. This has currently been solved by performing the selection

f = self.off_diag_f if self.mixer == AlphaMixer else self.f

prior to solving the right hand sides of the t- and l-amplitudes. We should be able to set up the same usage for both AlphaMixer and DIIS where both use the off-diagonal version of the Fock matrix or the full version.