search

Hydr8gon / NooDS

A (hopefully!) speedy DS emulator
GNU General Public License v3.0
884 stars 47 forks source link

[WIP] Add libretro core support #156

Open jonian opened 4 months ago

jonian commented 4 months ago

Hi,

This is the initial implementation of a libretro core as requested in issue #141. It still requires additional work, including screen rotation and cheats support, among other improvements.

Would you be open to accepting the final implementation into the main repository once the core is complete, or would you prefer that I continue development in a separate fork?

Looking forward to your guidance.

BelleNottelling commented 3 months ago

https://github.com/Hydr8gon/NooDS?tab=readme-ov-file#contributing

This is a personal project, and I've decided to not review or accept pull requests for it. If you want to help, you can test things and report issues or provide feedback. If you can afford it, you can also donate to motivate me and allow me to spend more time on things like this. Nothing is mandatory, and I appreciate any interest in my projects, even if you're just a user!

jonian commented 3 months ago

I have seen that section in the readme but the comment in the issue leaves the possibility open. Maybe I'm understanding something wrong since english is not my native language.

This isn't something that I'd be willing to maintain myself, but someone else could if they wanted to.

Anyway, no pressure to the author/owner of the repository to merge or even comment on this.

Hydr8gon commented 3 months ago

Since this isn't something that I'll be maintaining, I think it should be kept as a separate fork. That said, I don't mind the PR staying open so that people can find it. Nice work, by the way; it's cool to see my project get ported like this!

jonian commented 3 months ago

Thank you for the kind words! I agree that keeping it in a separate fork is better and I appreciate you leaving the PR open for visibility. I'm still learning about C++, libretro, and emulators, so if you have any suggestions, feel free to comment here or open an issue on my forked repo, if you have time.

jonian commented 3 months ago

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

radicalten commented 3 months ago

Thank you for your great work here @jonian and @Hydr8gon!

I would also like to notify @saulfabregwiivc about the completion of the libretro core for this project. If he is interested, perhaps he could recompile it to work with a stable version of RA Wii?

Cheers!

Hydr8gon commented 3 months ago

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

@jonian Of course, go ahead!

saulfabregwiivc commented 2 months ago

Thank you for your great work here @jonian and @Hydr8gon!

I would also like to notify @saulfabregwiivc about the completion of the libretro core for this project. If he is interested, perhaps he could recompile it to work with a stable version of RA Wii?

Cheers!

hey, saw i got pinged here, i'll take a look at this project and see if i can modify the Makefile and others for try to compile for Wii.

saulfabregwiivc commented 2 months ago

@jonian hey there pal, is there any way for add these two platforms Wii and Wii U in Libretro makefile? I can't figure out how i can add specific platform defines for Libretro makefiles with all its required defines and others (such WIIU). And i'd like to compile a Wii version of this core for see how it performs.

ztf147 commented 1 month ago

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

Do you have a plan to make a Switch build in the future? coz you know on switch we can record past videos for 30 seconds, just better then other mobile platforms i think

warmenhoven commented 6 days ago

Hi @Hydr8gon, the core is on the libretro buildbot now and currently compiling for android, macOS/iOS/tvOS, windows, and linux. Would you be ok with it being available in the macOS/iOS/tvOS App Store builds?

Also @saulfabregwiivc, the Makefile.libretro now has the beginnings of what's necessary for Wii/WiiU (and Switch as well). There's still a bit more that's necessary for them, and as I'm unfamiliar with their toolchains, I'd appreciate any help you can offer getting them over the finish line.

Hydr8gon commented 6 days ago

@warmenhoven oh, cool! I don't have a problem with it being on the App Store, so go ahead.