search

Hydr8gon / VitaControl

Use bluetooth controllers on your Vita!
79 stars 13 forks source link

Add support for Xbox One controllers with the original 2016 firmware #9

Closed ticky closed 2 years ago

ticky commented 2 years ago

The original firmware for the Xbox One controllers used a slightly different report format, with most buttons bunched up together in one byte.

I've added support for this older firmware before, to SDL and the like. Adding it here makes it work great on my vita!

For reference, controllers reporting a PID of 0x02FD are the first revision with the current report format, 0x2E0 is the only PID I know that has the older one.

I'm not hugely familiar with C++, so if there's a nicer way to do this that doesn't involve quite so much duplication I'm all ears. Thanks!

Hydr8gon commented 2 years ago

Code-wise, everything looks good. I'm wondering about the reliability of the PID check, though. If a controller with PID 0x2E0 has its firmware updated, does the PID change? Otherwise, it would be possible that updated controllers no longer work with this.

ticky commented 2 years ago

My understand is that the firmware update changes the reported PID

Hydr8gon commented 2 years ago

Awesome, I'll merge this then. Thanks!