HydraCG / Specifications

Specifications created by the Hydra W3C Community Group
Other
138 stars 26 forks source link

add two more collections: people & venues #136

Closed elf-pavlik closed 6 years ago

elf-pavlik commented 6 years ago

This PR simply adds two more collections to the entry point to make use case closer to datasets on real word eventing services. It also helps exemplify need discussed in #126 and currently implemented in #132

This EntryPoint should also help with driving implementation of Heracles.ts with respect to distinguishing among collections advertised in the entry point.

In future PRs I will propose various relations betweens events, people and places eg. schema:location and schema:attendee also providing use case for #134


This change is Reviewable

elf-pavlik commented 6 years ago

@lanthaler @alien-mcl this PR proposes what I understood that we discussed during last telecon This PR doesn't change anything in the narrative, in future PR where I will propose relations between events, people and venues I will also include extended narrative.

lanthaler commented 6 years ago

Looks great. Thanks Pavlik. Unless anyone objects, I'd like to merge this as soon as Pavlik fixed the minor coding style issues.


Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


drafts/use-cases/1.1.security-considerations.md, line 29 at r1 (raw file):

                    "operation": [
                        {
                           "@type": ["hydra:Operation", "schema:CreateAction"],

Could you please fix the indentation of @type here. And while you are at it, could you please also simplify this and the blocks below by not wrapping a single operation into an array.


drafts/use-cases/1.entry-point.md, line 38 at r1 (raw file):

    "@type": "hydra:EntryPoint",
    "collection": [
      {

Please make the indentation consistent. We have a mixture of 2 and 4 spaces in this file. I like 2 :-)


Comments from Reviewable

elf-pavlik commented 6 years ago

drafts/use-cases/1.entry-point.md, line 38 at r1 (raw file):

Previously, lanthaler (Markus Lanthaler) wrote…
Please make the indentation consistent. We have a mixture of 2 and 4 spaces in this file. I like 2 :-)

Done. 2 spaces as in https://standardjs.com/


Comments from Reviewable

elf-pavlik commented 6 years ago

drafts/use-cases/1.1.security-considerations.md, line 29 at r1 (raw file):

Previously, lanthaler (Markus Lanthaler) wrote…
Could you please fix the indentation of `@type` here. And while you are at it, could you please also simplify this and the blocks below by not wrapping a single operation into an array.

Done.


Comments from Reviewable

lanthaler commented 6 years ago

:lgtm: Thanks Pavlik


Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable