search

HydraheadHunter / Data-Driven-Stacks

Makes max_stack_size more data-driven. Increase cap on it's value from 99 to 2048
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Minecraft Refuses to Load with latest version on Prism Launcher #10

Closed G93d14 closed 1 month ago

G93d14 commented 1 month ago

A copy of my log: https://mclo.gs/2xJjJsT

I will revert to the previous version for now.

G93d14 commented 1 month ago

log with previous version in case it is useful: https://mclo.gs/BzOcd7l

HydraheadHunter commented 1 month ago

Before I look into this, if you'd be willing to check if v0.9.3 also crashes your game, I'd greatly appreciate it.

I changed quite a few things on the back-end for this version to get player/non-player stack size differences working acceptably well, and it'd be good to know if the new, most-recent, version is still causing you problems or if by some miracle I fixed it accidently.

G93d14 commented 1 month ago

I wasn't able to check v 0.9.3, but 0.9.4 still crashes my game. v0.9.4 log

HydraheadHunter commented 1 month ago

(0.9.3 had a major crashing bug unrelated to this issue which I caught immediately after uploading but not before this comment, and I forget to get around to correcting my most recent version).

Yep, certainly does. Something changed in the fabric load twixt FabricLoader 15.11 and FabricLoder 16 that broke at one of my mixins. I'll see what I can do about fixing the problem for ya.

HydraheadHunter commented 1 month ago

I've updated to Fabric Loader 16.0 is a branch, and it seems to really just not not liking ScreenHandler;modifyItemStack2(...)

I don't understand why it doesn't like the method, but as a hot-fix, I've built a compatability version which removes the offending method without replacement. The removed method is responsible for changing 'click-and-drag' behavior of items configured to have different stacksizes twixt player/non-player inventories, so this compatability version won't have that feature.

But, the game shouldn't crash.

Please, check Data Driven Stack Sizes 0.9.4-1.21-FL16-compat to see whether this is the case.

G93d14 commented 1 month ago

I've been using fabric loader 16 since I started playing in 1.21, and 0.9.0 was working fine there. I'm not using differing stack sizes for players anyway, so if that's the only change I don't think it will affect my game.

I'll check it out when I next open minecraft.

G93d14 commented 1 month ago

it loads up with this compatibility version fine. Here is the log for your reference.

G93d14 commented 1 month ago

wait no it's not actually working, nothing new stacks above 64

HydraheadHunter commented 1 month ago

Please check if the problem persists in v0.9.5.

Please also check that if you were using the villager_stack_less tag that you've renamed the directory from entity to control.

G93d14 commented 1 month ago

hey, I haven't been able to check the villagers_stack_less part yet but v0.9.5 works fine qith fabric loader v0.16.

HydraheadHunter commented 1 month ago

Wonderful. Then i'll be closing this issue