search

HydraheadHunter / Data-Driven-Stacks

Makes max_stack_size more data-driven. Increase cap on it's value from 99 to 2048
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Mod intended to be Server-Side only. Does not function without Client-Side Copy. #7

Closed HydraheadHunter closed 1 month ago

HydraheadHunter commented 1 month ago

Seporating this into an individual issue from the initial issue raising it: The server-side mod doesn't have full functionality without client-side support.

I'm unsure of the cause.

TheRonGDD commented 1 month ago

Not sure who reported this, but I would be happy to test their configuration. I have no issues running this server side only. It might be a config issue as I did experience that.

HydraheadHunter commented 1 month ago

Might just be my magic touch (derogatory) making it not work for me without also being client-side.

I ran into this issue initially looking into your issue: running the mod on an out-of-the-box fabric server (mc1.21 - loader 0.15.11) with nothing but the fabric api (0.100.4 for 1.21), intially without the mod installed on my client. To see if your issue was more than just item instead of items.

I've tried both the 0.8.5 example pack and the newer 0.9.0 example pack.

HydraheadHunter commented 1 month ago

Might be an idiot. Fabric api 100.4 compiles, but my mod's dependancies are listed as 100.6+: might be what's causing my troubles...

It was not. Still might be an idiot, but that's unrelated.

sternschnaube commented 1 month ago

Seporating this into an individual issue from the initial issue raising it: The server-side mod doesn't have full functionality without client-side support.

I'm unsure of the cause.

Any update on this? 🤔

HydraheadHunter commented 1 month ago

Well, I still have no idea about what the cause was, but survival gameplay seems to be working correctly as of 0.9.5, so I'mma move things back to serverside and keep an eye on it.

sternschnaube commented 1 month ago

Great to hear 😄 I have another question: What happens if the mod gets removed, do stack gets counted down to x64 (if it was at least x65)? No harm to the world?

HydraheadHunter commented 1 month ago

There'd be no harm to the world as long as no stacks exist with a max stack size over 99.

Part of minecraft stack validation is checking the max_stack_size item component against the 'max stack size cap' which is 99. If a stack is declared invalid (as it would do if it found a x100 stack of dirt without the mod installed), minecraft throws a hissy abouts it, and that hissy crashes the world.

If you don't have any x100+ stacks in the world, you're perfectly safe to uninstall.

But if you do have any, you'll need to find every stack that's too large and get both them and their max_stack_size component down to at most99` to safely uninstall.