HydroProtocol / hydro-scaffold-dex

A Decentralized Exchange Scaffold - launch a DEX in minutes
Apache License 2.0
197 stars 189 forks source link

Docker is exposing an unsecured redis service (port 6379) to the outside #54

Closed jspedros closed 5 years ago

jspedros commented 5 years ago

Docker is exposing an unsecured redis service (port 6379) to the outside. Most of the images are exposing ports to the world outside Docker when this may not be necessary. This is a security issue if not using a firewall.

image

Recommend changing ports to expose in docker-compose.yaml for images that don't need to be accessed from outside Docker.

_image: redis:5.0 expose:

davidqhr commented 5 years ago

Thanks, I will look into this.

davidqhr commented 5 years ago

Now the services are only exposed to the localhost network. The docker-compose way is just a convenience for demo purposes. For anyone using hydro scaffold dex, it's not commended to deploy directly with the default docker compose file.