Pull Request to Read officeid from config file

HydrologicEngineeringCenter / ExcelToCWMS

1 stars 2 forks source link

Pull Request to Read officeid from config file #11

Closed Tich1212 closed 3 years ago

Tich1212 commented 3 years ago

Why: Pull request addresses issues #7 . Previously we had a temporary hard code office ID for connecting to Oracle. Now we reading it from the config file. This will make the app useful for other districts.

How: Created a new config reader class that is a generic file reader to ask the file for specific values. Now we can call ConfigReader.CRead("officeid") to get the office id string. Hopefully we can use that elsewhere as well.

Tich1212 commented 3 years ago

Looks good!

small detail: /// officeid:NWDM --- is in the comments in Oracle.cs

Oops. Removed that from the method description. d1f0b76