HydrologicEngineeringCenter / ExcelToCWMS

1 stars 2 forks source link

time zone is hardcoded to UTC #22

Closed ktarbet closed 3 years ago

ktarbet commented 3 years ago

code in https://github.com/HydrologicEngineeringCenter/ExcelToCWMS/blob/main/Hec.Cwms/CwmsDatabase.cs

is hardcoded to 'UTC' in this statement



      cmd.CommandText =
     "begin " +
     "  cwms_ts.retrieve_ts( " +
     "    :ts_cur, " +
     "    :tsid, " +
     "    :units, " +
     "    to_date(:start_time, 'dd-mon-yyyy hh24mi'), " +
     "    to_date(:end_time,   'dd-mon-yyyy hh24mi'), " +
     "    'UTC');" +
     "end;";

Should the time zone be an optional in the excel header:  ie.   tsid.daily....{units=cfs, time-zone=cst} ?
Tich1212 commented 3 years ago

Can i add this comment to #17 and consider this duplicate?

Tich1212 commented 3 years ago

Moved comment, marked dup and closed.