search

HydrologicEngineeringCenter / HEC-FDA

Hydrologic Engineering Center - Flood Damage Analysis
MIT License
11 stars 2 forks source link

importer cannot handle spaces in places where data is intended to be missing #1032

Open rnugent3 opened 10 months ago

rnugent3 commented 10 months ago

Our importer cannot handle situations where we have a space in a in a tab delimited row which is remnant from editing data. When you open up the attached file in Excel, you'll see that there is a space in cell L8.

The importer will create the set of occupancy types, but not import any because they all have this extra space character. No message is provided to the user.

occTypes-allNormal.txt

rnugent3 commented 10 months ago

@Brennan1994 bad news ... there is something wrong with this file (I couldn't figure it out) that 1.4.3 could handle, that our importer cannot

rnugent3 commented 10 months ago

I successfully imported into 1.4.3, then re-exported, and successfully imported into 2.0

rnugent3 commented 10 months ago

I assigned a priority label to this because I think that the format issue came out of a typical workflow in editing occupancy type files, and so typical format issue that our 1990s software handles it.

rnugent3 commented 9 months ago

image It looks like the primary difference between the file that works in 2.0 and that which does not (but does work for 1.4.3) is a missing -901.

rnugent3 commented 9 months ago

THERE IS MORE THAN 1000 LINES OF CODE SPECIFICALLY FOR HANDLING OCC TYPE IMPORT!