HydrologicEngineeringCenter / HEC-FDA

Hydrologic Engineering Center - Flood Damage Analysis
MIT License
11 stars 2 forks source link

We need more compute points at the bottom for weird situations #1152

Closed rnugent3 closed 1 month ago

rnugent3 commented 1 month ago

I had programmed the aggregated stage-damage compute to use less compute points between the most frequent event in the hydraulics data set and the .999 stage, but it turns out we need more compute points because we can miss important nonlinearity beyond the most frequent event in the hydraulics data set when there is positive damage at that event.

Before the fix, there is a 4-ft gap between the 0.5 AEP stage and the next more frequent stage. image

After the fix, the difference is about 0.5 ft. image

rnugent3 commented 1 month ago

We got such a big range of stages at the bottom of the stage-damage function for this study because there is a 0 discharge stage in the stage-discharge function. image

rnugent3 commented 1 month ago

Hold off on reviewing. I need to think through a more flexible approach. We'll be adding many compute points for many situations where they do nothing but add computational expense.

rnugent3 commented 1 month ago

@Brennan1994 this is ready for your review