HydrologicEngineeringCenter / Vortex

data processing utilities
MIT License
26 stars 7 forks source link

`importer` interpolating with input grids no data value #16

Open danhamill opened 3 years ago

danhamill commented 3 years ago

When I run importer to clip and resample a daily UA grid to the Truckee Watershed, its interpolating with the input grids nodata value in the lake Tahoe region.

Input grid: 2020_03_22.zip

clipping shape: TruckeeBasinShapefile.zip

Result: image

tombrauer commented 3 years ago

Long term solution: I should probably give the user more control over specifying no data values for source data. Short term solution: you can use the sanitizer utility to clean up values above or below a threshold. I would try running the sanitizer on the input grids. When you filter values below a threshold, try leaving the replacement value blank. This should replace values with NaN which is what the importer uses for no data.

danhamill commented 3 years ago

I will give it a try. That sounds like a reasonable workaround. Thanks!

danhamill commented 2 years ago

Just tested on v0.10.28-rc.6 and the dss records are not tracking no-data during import.

image

image

Wasn't this added in v0.10.28-rc.4?

tombrauer commented 2 years ago

@danhamill please test v0.10.28-rc.9 I added no data handling to the NetcdfDataReader class.

I'm not sure when the max/min/mean was added to the GridInfo. For all I know it's been there all along, but I haven't paid very close attention. I did just update some DSS dependencies so it could have been a part of that, or it could be a new version of HEC-DSSVue.