search

HydrologicEngineeringCenter / fda-model

A simple computational library to support water resources.
MIT License
2 stars 0 forks source link

Namespace Issues #365

Open Brennan1994 opened 2 years ago

Brennan1994 commented 2 years ago

Throughout model we have horrible and inconsistent namespaces. Best practices here: https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-namespaces

This is becoming an issue when trying to reference things in Model from veiwmodel. Nothing is prefixed with anything that indicates it's coming from fda-model. To access Inventory.cs, for example, you'd assume based on folder structure the path would be something like HEC.FDA.Model.structures.Inventory, the reality is the correct path is just structures.Inventory.

So far this is just annoying, but could potentially cause conflicts when path names start becoming non-unique. This ought to be fixed at some point, and the issue grows the longer we let it sit, because going through and fixing these namespaces is going to change the method signatures of EVERYTHING we reference in the view.

HenryGeorgist commented 2 years ago

we should not be referencing model in the view. am i missing something?