Hydrospheredata / hydro-serving

MLOps Platform
http://docs.hydrosphere.io
Apache License 2.0
271 stars 42 forks source link

Docker builds images even on unsuccessful pip installation #215

Closed tidylobster closed 6 years ago

tidylobster commented 6 years ago

RUN ls /model/files/requirements.txt && pip install -r /model/files/requirements.txt --target /model/lib || echo "no requirements"

Try to create an empty requirements.txt one step before installing it with pip.

KineticCookie commented 6 years ago

Need to modify the BuildScript for python models.

KineticCookie commented 6 years ago

Waiting for @tidylobster's bug reproduction

KineticCookie commented 6 years ago

219 provides a safer pip build script.