search

Hydrospheredata / hydro-serving

MLOps Platform
http://docs.hydrosphere.io
Apache License 2.0
271 stars 42 forks source link

Unable to rename application in certain circumstances #276

Closed KineticCookie closed 5 years ago

KineticCookie commented 5 years ago

After investigating the issue I came up with following problems:

  1. ApplicationService.update method doesn't care about existing Servables. If user updates application's name, servablesToCreate set will be empty, and internal mapping will fail.
  2. Looks like this commit https://github.com/Hydrospheredata/hydro-serving-manager/commit/ca743841e52a7b99e09bc64039abbdc7b5116151 deleted Servable Repository, and manager service no longer able to maintain Servable Status handling properly. In addition to that, the only way to get the list of all Servables is to use CloudDriver. This is becomes an even bigger issue, if we want to implement a proper Servable pings and lifecycle management. Could be back-incompatible.
KineticCookie commented 5 years ago

The proper hotfix for now is to reimplement ApplicationService.update method in terms of consequent deletion and creation. This makes sense, but computational heavier.

KineticCookie commented 5 years ago

06c28bda7977c5154946de8e54675d7520639b33 could contain servable db repository