Hydrospheredata / mist

Serverless proxy for Spark cluster
http://hydrosphere.io/mist/
Apache License 2.0
326 stars 68 forks source link

[feature/aws_setup] Fix dependency on default VPC and avoid recreating ingress rule. #532

Closed snadorp closed 5 years ago

snadorp commented 5 years ago
  1. The setup was depending on eiither classic VPC or default VPCs. If there is no default VPC Security groups cannot be easily filtered by group name. To be able to query them from the API a Filter needs to be constructed.

  2. Ingress rules where not checked for existence, meaning a second run of the setup script would fail, this case has been covered by silently ignoring exactly this case, thus not failing the setup procedure.

dos65 commented 5 years ago

Awesome! LGTM. I'll merge this and update preview artifacts after testing it on aws.