search

Hydrospheredata / mist

Serverless proxy for Spark cluster
http://hydrosphere.io/mist/
Apache License 2.0
326 stars 68 forks source link

Doobie integration #541

Closed asaushkin closed 5 years ago

asaushkin commented 5 years ago

These changes add doobie integration with Hikari connection pool. Supported databases are H2 and PostgreSQL. Currently Slick integration is not removed and may be used as well as early.

Default master configuration is H2 over new Doobie with Hikari coonection pool.

dos65 commented 5 years ago

Great! Thanks for your contribution. Now, we almost ready to publish a new release.

Everything is fine except tests and Travis setup. Unfortunately, last commits about Travis don't fit for our case. It's hard to explain why, but we use two CI servers: Travis and Jenkins. Moving this spec to integrations tests is the best way to keep these tests. There we can run PostgreSQL as a docker container and this approach allows us not to care about an environment and run these test anywhere where docker is installed.

Actually, it would be enough just to remove last 5 commits to merge this PR. If you don't have enough time, I can complete this testing stuff after merge by myself.

asaushkin commented 5 years ago

I think only last four commits are extra. This one https://github.com/Hydrospheredata/mist/pull/541/commits/8dfd16372d16cfceb9f7156aa038e3ebb10acc89 is mandatory for the project build. I'd appreciate you help if you will convert these tests to the integration test by yourself.

dos65 commented 5 years ago

Yes, you right - 4 would be enough. Could you please edit history and remove these commits?

asaushkin commented 5 years ago

I've just removed last three commits. The fourth mark Pg test as abtract and is mandatory to run tests without any fail.