search

Hydrospheredata / mist

Serverless proxy for Spark cluster
http://hydrosphere.io/mist/
Apache License 2.0
326 stars 68 forks source link

Generic JSON encoder for case-classes #546

Open otto-dev opened 5 years ago

otto-dev commented 5 years ago

Allows conversion of any Scala case class and tuples to/from JSON by importing mist.api.encoding.defaults._. Makes it unnecessary to create encoders for case classes.

Encoders for specific classes (case classes) will continue to take precedence over this generic encoder and extractor. Hence the ability to create specific encoders remains unaffected, and existing code will not break.

Derived from the examples in the documentation. I can't build and test mist locally beyond compilation because of time constrains.

I'm not sure if the import of shadedshapeless.Lazy is necessary.

Also, feel free to reject this pull request if there is a reason why this hasn't been implemented yet.

otto-dev commented 5 years ago

CI fails with a python syntax error thrown by a third party module pytest

dos65 commented 5 years ago

I think it would be better to choose the most standard way in the ecosystem and put these instances into auto object. Like circe and pureconfig do this.

otto-dev commented 5 years ago

Sounds good to me. As long as you have a way to delegate the encoder creation to Scala. Planning to have a look when I find time, unless someone beats me to it. I first have to set up the build & test environment.