Hyle-org / hyle

A sequencing and settlement layer to help you build provable apps that are minimally, yet sufficiently, onchain.
30 stars 14 forks source link

Implement verification for Halo2 ZK proofs #27

Closed wraitii closed 1 month ago

wraitii commented 4 months ago

The purpose of this issue is to implement verification of Halo2 proofs on Hylé.

This should be done using a subprocess call a rust verifier, similar to our risczero implementation. See instructions on https://github.com/axiom-crypto/halo2-scaffold/ for integration

Additionally, the matching verifier must be implemented in the verifier repository → https://github.com/Hyle-org/verifiers-for-hyle/issues/11

This PR is related to the “WebAuthn signer support” PR → https://github.com/Hyle-org/webauthn-identity-provider/issues/1

RajeshRk18 commented 4 months ago

Shall I take up this?

wraitii commented 4 months ago

Shall I take up this?

If you're still up for this, go ahead :)

RajeshRk18 commented 4 months ago

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

wraitii commented 4 months ago

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

In principle we want a general verifier - you should take a Verification Key (or similar) and a proof and output whether the proof is correct or not.

RajeshRk18 commented 4 months ago

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

In principle we want a general verifier - you should take a Verification Key (or similar) and a proof and output whether the proof is correct or not.

Like in the axiom's halo2 scaffold right?

Here is how it will look like;

wraitii commented 4 months ago

Like in the axiom's halo2 scaffold right?

  • A separate repo for halo2 prover
  • A verifier in the verifier repo

Most likely, not really familiar with the axiom scaffold. We don't per-se need a prover, but an example application would be good.

guha-rahul commented 3 months ago

Can i work on this?

wraitii commented 3 months ago

Can i work on this?

Hey @guha-rahul , I've assigned you. Don't hesitate to ask question on Telegram if there's any issue: https://t.me/+ziFJlAUfPlU1NzRk