search

Hyle-org / verifiers-for-hyle

Apache License 2.0
10 stars 9 forks source link

Add midenVM verifier #16

Closed dragan2234 closed 3 months ago

dragan2234 commented 3 months ago

MidenVM verifier implementation with an example.

Proof can be verified like this:

target/debug/midenvm-verifier 78d31702eb946e1817e3c0881fcb3739562f08fbddf202de2eae241b9968ab3b ./midenvm-verifier/example/fib.proof ./midenvm-verifier/example/fib.inputs ./midenvm-verifier/example/fib.outputs

My question is what should I return for HyleOutput<()>, are there any docs related to this? And is there anything that I missed?

dragan2234 commented 3 months ago

ready for a review @wraitii

dragan2234 commented 3 months ago

@wraitii @maximilien-hyle I've added some instructions to README.md file. In order to generate necessary files (and a program hash) for the proof, user needs to install https://github.com/0xPolygonMiden/miden-vm (meaning they need rust and whole setup etc. - should be trivial) and follow their instructions from here: https://0xpolygonmiden.github.io/miden-vm/intro/usage.html#running-miden-vm so I've just put the link to official miden-vm tutorial.

I still didn't remove the example folder since this can't be generated from inside this repo, so I left it so somebody can run the example, lmk if you still want it removed.

Regarding HyleOutput object, it needs all fields populated (I can't just pass stack_outputs to next_state and that's it). So I'm still not sure what to put for other fields (maybe I'm still missing something).

wraitii commented 3 months ago

Regarding HyleOutput object, it needs all fields populated (I can't just pass stack_outputs to next_state and that's it). So I'm still not sure what to put for other fields (maybe I'm still missing something).

You could actually, but we'll probably need to change them at a later point anyways. I think as far as we're concerned the PR is relatively good to go, but I'll do another pass with @maximilien-hyle

wraitii commented 3 months ago

(@dragan2234 We can do some follow-ups but we need to figure out a few things first)

dragan2234 commented 3 months ago

@maximilien-hyle @wraitii Thank you! Let me know about the follow-up task too. By the way, how can I contact you on telegram? This is my nick: @djaganche