Closed thomasgwatson closed 10 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
db7b096
) 46.65% compared to head (8474eb4
) 46.65%. Report is 3 commits behind head on dev.:exclamation: Current head 8474eb4 differs from pull request most recent head 16eda19. Consider uploading reports for the commit 16eda19 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yeah, I was getting it in my head that urls are case-insensitive but that doesn't apply to query strings
On Sat, 14 Oct 2023 at 10:19, Tibet Sprague @.***> wrote:
@.**** approved this pull request.
In src/routes/ChatRoom/ChatRoom.connector.js https://github.com/Hylozoic/hylo-evo/pull/1555#discussion_r1359494001:
const search = getQuerystringParam('search', state, props)
- const postIdToStartAt = querystringParams?.postid
Oh one more little thing, let’s call this postId
— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1555#pullrequestreview-1678244090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AQF7JTNRRWRZRZ5ZYLX7LCQJAVCNFSM6AAAAAA54PJO6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNZYGI2DIMBZGA . You are receiving this because you authored the thread.Message ID: @.***>
Contributes to https://github.com/Hylozoic/HyloReactNative/issues/663
This should be SAFE to merge, it only adds new functionality, no changes to routing etc