Hylozoic / hylo-evo

Hylo UI
Apache License 2.0
36 stars 10 forks source link

Let chatroom scroll to a specific chat #1555

Closed thomasgwatson closed 10 months ago

thomasgwatson commented 11 months ago

Contributes to https://github.com/Hylozoic/HyloReactNative/issues/663

This should be SAFE to merge, it only adds new functionality, no changes to routing etc

codecov[bot] commented 11 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (db7b096) 46.65% compared to head (8474eb4) 46.65%. Report is 3 commits behind head on dev.

:exclamation: Current head 8474eb4 differs from pull request most recent head 16eda19. Consider uploading reports for the commit 16eda19 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1555 +/- ## ======================================= Coverage 46.65% 46.65% ======================================= Files 568 568 Lines 13254 13257 +3 Branches 3788 3790 +2 ======================================= + Hits 6183 6185 +2 - Misses 7071 7072 +1 ``` | [Files](https://app.codecov.io/gh/Hylozoic/hylo-evo/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hylozoic) | Coverage Δ | | |---|---|---| | [src/routes/ChatRoom/ChatRoom.js](https://app.codecov.io/gh/Hylozoic/hylo-evo/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hylozoic#diff-c3JjL3JvdXRlcy9DaGF0Um9vbS9DaGF0Um9vbS5qcw==) | `1.04% <0.00%> (ø)` | | | [src/routes/ChatRoom/ChatRoom.connector.js](https://app.codecov.io/gh/Hylozoic/hylo-evo/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hylozoic#diff-c3JjL3JvdXRlcy9DaGF0Um9vbS9DaGF0Um9vbS5jb25uZWN0b3IuanM=) | `2.66% <0.00%> (-0.12%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Hylozoic/hylo-evo/pull/1555/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hylozoic)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomasgwatson commented 10 months ago

Yeah, I was getting it in my head that urls are case-insensitive but that doesn't apply to query strings

On Sat, 14 Oct 2023 at 10:19, Tibet Sprague @.***> wrote:

@.**** approved this pull request.

In src/routes/ChatRoom/ChatRoom.connector.js https://github.com/Hylozoic/hylo-evo/pull/1555#discussion_r1359494001:

const search = getQuerystringParam('search', state, props)

  • const postIdToStartAt = querystringParams?.postid

Oh one more little thing, let’s call this postId

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1555#pullrequestreview-1678244090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AQF7JTNRRWRZRZ5ZYLX7LCQJAVCNFSM6AAAAAA54PJO6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNZYGI2DIMBZGA . You are receiving this because you authored the thread.Message ID: @.***>