Evo 1533 responsibilities

[thomasgwatson]

When completed, closes #1533

[tibetsprague]

im assuming not ready for review?

[thomasgwatson]

The main thing that needs to be added is tests. But functionally complete and if you want to start working through the review (it's over 75 files touched, not including snapshotn updates), you can do so

On Sun, Dec 31, 2023, 09:13 Tibet Sprague @.***> wrote:

im assuming not ready for review?

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1577#issuecomment-1872616241, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4ARAYMBUKD5VCTMVYTDYMCGYXAVCNFSM6AAAAABBFEJ2GSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGYYTMMRUGE . You are receiving this because you authored the thread.Message ID: @.***>

[thomasgwatson]

screen-capture.webm

screen-capture (1).webm

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 34.78261% with 195 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (f373f52) to head (c5a0690). Report is 2 commits behind head on dev.

:exclamation: Current head c5a0690 differs from pull request most recent head c1a779d

Please upload reports for the commit c1a779d to get more accurate results.

Files	Patch %	Lines
...ettings/ResponsibilitiesTab/ResponsibilitiesTab.js	2.40%	81 Missing :warning:
...ngs/ModeratorsSettingsTab/ModeratorsSettingsTab.js	6.09%	77 Missing :warning:
src/store/actions/responsibilities/index.js	0.00%	16 Missing :warning:
src/store/actions/roles/index.js	0.00%	5 Missing :warning:
src/routes/ChatRoom/ChatPost/ChatPost.js	0.00%	4 Missing :warning:
src/routes/GroupDetail/GroupDetail.js	0.00%	2 Missing :warning:
src/store/models/CommonRole..js	50.00%	2 Missing :warning:
src/components/Member/Member.js	75.00%	1 Missing :warning:
src/components/PostCard/PostHeader/PostHeader.js	50.00%	1 Missing :warning:
src/routes/GroupSettings/GroupSettings.js	96.66%	1 Missing :warning:
... and 5 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1577 +/- ## ======================================= Coverage 47.17% 47.18% ======================================= Files 575 573 -2 Lines 13723 13673 -50 Branches 3958 3936 -22 ======================================= - Hits 6474 6451 -23 + Misses 7249 7222 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[KevinTriplett]

What is the priority of this PR? I would be glad to help in a live discussion.

[tibetsprague]

This is too much for you to jump in on. I’m on it On Apr 9, 2024, at 8:03 PM, Kevin Triplett @.***> wrote: What is the priority of this PR? I would be glad to help in a live discussion.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

[tibetsprague]

Good catch!

On Jun 20, 2024, at 12:00 PM, Tom Watson @.***> wrote:

@thomasgwatson commented on this pull request.

In src/components/CreateGroup/CreateGroup.connector.js https://github.com/Hylozoic/hylo-evo/pull/1577#discussion_r1648012581:

const parentGroupOptions = (currentUser && currentUser.memberships.toModelArray()

• .filter(m => m.hasModeratorRole || m.group.accessibility === GROUP_ACCESSIBILITY.Open)
• .filter(m => m.group.accessibility === GROUP_ACCESSIBILITY.Open || hasResponsibilityForGroup(state, { groupId: m.groupId, RESP_ADMINISTRATION })) I suspect this line doesn't work? RESP_ADMIN needs to be keyed as responsibility. And seeing some cases where responsibility is a string and others where its an array of strings, assuming thats ok

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1577#pullrequestreview-2131154546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HMD3INUDINPFO52HY3ZIMRGRAVCNFSM6AAAAABBFEJ2GSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZRGE2TINJUGY. You are receiving this because you commented.

[thomasgwatson]

Hopefully we'll replace this with subscriptions via urql soonish!

On Wed, Jul 24, 2024, 09:39 Tibet Sprague @.***> wrote:

@.**** commented on this pull request.

In src/routes/AuthLayoutRouter/AuthLayoutRouter.js https://github.com/Hylozoic/hylo-evo/pull/1577#discussion_r1688879681:

@@ -422,6 +424,7 @@ export default function AuthLayoutRouter (props) {