Closed KevinTriplett closed 8 months ago
There's a few more things/places I want to make sure you've tested
@tibetsprague , Thanks for advising testing it as an event and resource and such, with the different views. It seems well behaved, if clipping the title is what's desired / expected. Opening the item displays the full title with no overlapping. Looks good, but I wouldn't say I did an exhaustive test, more like a sample with no obvious errors.
looks good except for my one comment about the error message
Test and code reverted
@tibetsprague I've scheduled a zoom meet so you can walk me through the way shallow wrappers work. I'm feeling a bit dense -- I've coded something that seems like it should work but the wrapper find
method is returning an empty object despite me asking for even just a 'div'
element. Reading the manuals isn't helping me for some reason. Thanks
it('renders announcement option with admin in props', () => {
const props = {
...baseProps,
canModerate: true
}
const wrapper = shallow(<PostEditor {...props} />)
expect(wrapper).toMatchSnapshot()
expect(wrapper.find('span[data-tip="Send Announcement"]')).not.toBeNull()
closes #1299 increase title length from 50 to 80, with tests and updates to other files to allow passing tests.
In the following screenshots, ignore the comment, the full 80 character title is shown