Closed tibetsprague closed 6 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
3cf0bf7
) 47.29% compared to head (1e11c82
) 47.42%. Report is 49 commits behind head on dev.:exclamation: Current head 1e11c82 differs from pull request most recent head bb5c340. Consider uploading reports for the commit bb5c340 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ahh yes, tags => topics
On Mon, 19 Feb 2024 at 12:59, Tibet Sprague @.***> wrote:
@.**** commented on this pull request.
In src/store/models/Notification.js https://github.com/Hylozoic/hylo-evo/pull/1591#discussion_r1495009556:
const tagReason = find(r => r.startsWith('tag: '), reasons)
const topicName = tagReason.split(': ')[1] return postUrl(post.id, { groupSlug, topicName })
- }
- case ACTION_NEW_POST:
- return postUrl(post.id, { groupSlug })
oh actually this already works, if there is a topic on the post it goes to ACTIOB_TAG above which goes to the chat room with the post open
— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1591#discussion_r1495009556, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AWLPK4IUDDZT23XUX3YUO4KBAVCNFSM6AAAAABDMOULCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBZGE2TONJZGM . You are receiving this because you commented.Message ID: @.***>
Although... maybe it doesn't like it for #general ? I clicked on this notification (below pic) and it sent me to that url, which is the regular post one
Maybe because its a mention.
Yeah, it worked on an earlier Krisha chat notif. The mention must get picked up before the topic/tag
Ooh, I can move ACTION_TAG above mention to prioritize that URL
On Feb 19, 2024, at 1:04 PM, Tom Watson @.***> wrote:
Yeah, it worked on an earlier Krisha chat notif. The mention must get picked up before the topic/tag
— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1591#issuecomment-1953156067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HMWEAVVKDJMCWZTYQDYUO44DAVCNFSM6AAAAABDMOULCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGE2TMMBWG4. You are receiving this because you authored the thread.
ok fixed so if someone is mentioned in a chat room is goes to the chat room
Or just importantp posts = announcements and mentions
Fixes https://github.com/Hylozoic/hylo-evo/issues/1244