Hylozoic / hylo-evo

Hylo UI
Apache License 2.0
36 stars 10 forks source link

Add setting to receive a notification for every post #1591

Closed tibetsprague closed 6 months ago

tibetsprague commented 6 months ago

Or just importantp posts = announcements and mentions

Fixes https://github.com/Hylozoic/hylo-evo/issues/1244

codecov[bot] commented 6 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3cf0bf7) 47.29% compared to head (1e11c82) 47.42%. Report is 49 commits behind head on dev.

:exclamation: Current head 1e11c82 differs from pull request most recent head bb5c340. Consider uploading reports for the commit bb5c340 to get more accurate results

Files Patch % Lines
src/store/models/Notification.js 25.00% 3 Missing :warning:
...Nav/NotificationsDropdown/NotificationsDropdown.js 50.00% 2 Missing :warning:
...tRouter/ManageNotifications/ManageNotifications.js 66.66% 1 Missing :warning:
src/store/actions/updateNotificationSettings.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1591 +/- ## ========================================== + Coverage 47.29% 47.42% +0.12% ========================================== Files 567 569 +2 Lines 13258 13416 +158 Branches 3795 3850 +55 ========================================== + Hits 6271 6363 +92 - Misses 6987 7053 +66 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomasgwatson commented 6 months ago

ahh yes, tags => topics

On Mon, 19 Feb 2024 at 12:59, Tibet Sprague @.***> wrote:

@.**** commented on this pull request.

In src/store/models/Notification.js https://github.com/Hylozoic/hylo-evo/pull/1591#discussion_r1495009556:

   const tagReason = find(r => r.startsWith('tag: '), reasons)

const topicName = tagReason.split(': ')[1] return postUrl(post.id, { groupSlug, topicName })

  • }
  • case ACTION_NEW_POST:
  • return postUrl(post.id, { groupSlug })

oh actually this already works, if there is a topic on the post it goes to ACTIOB_TAG above which goes to the chat room with the post open

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1591#discussion_r1495009556, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AWLPK4IUDDZT23XUX3YUO4KBAVCNFSM6AAAAABDMOULCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBZGE2TONJZGM . You are receiving this because you commented.Message ID: @.***>

thomasgwatson commented 6 months ago

Although... maybe it doesn't like it for #general ? I clicked on this notification (below pic) and it sent me to that url, which is the regular post one

Maybe because its a mention.

Screenshot 2024-02-19 at 1 00 18 PM

thomasgwatson commented 6 months ago

Yeah, it worked on an earlier Krisha chat notif. The mention must get picked up before the topic/tag

tibetsprague commented 6 months ago

Ooh, I can move ACTION_TAG above mention to prioritize that URL

On Feb 19, 2024, at 1:04 PM, Tom Watson @.***> wrote:

Yeah, it worked on an earlier Krisha chat notif. The mention must get picked up before the topic/tag

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1591#issuecomment-1953156067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HMWEAVVKDJMCWZTYQDYUO44DAVCNFSM6AAAAABDMOULCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGE2TMMBWG4. You are receiving this because you authored the thread.

tibetsprague commented 6 months ago

ok fixed so if someone is mentioned in a chat room is goes to the chat room