search

Hylozoic / hylo-evo

Hylo UI
Apache License 2.0
36 stars 10 forks source link

Evo 1585 add duplicate post option #1608

Closed KevinTriplett closed 6 months ago

KevinTriplett commented 6 months ago

re-issuing PR with 4 organized commits to close #1585

KevinTriplett commented 6 months ago

lgtm, aside from the unanswered q or search matter.

Thanks for the review Tom! :)

@thomasgwatson and @tibetsprague, I looked and per line 79 of Stream.connector.js, 'search' is the param, not 'q'

Also, Hylo search is unique to me: I can't do an OR search, it only accepts one search term at a time. Is that correct?

KevinTriplett commented 6 months ago

looks good, but i still need to add the icon, so i will do that then merge

I suggest we use the "Copy" icon for duplicate and making a "Link" icon for Copy Link. Because that's really what's happening.

tibetsprague commented 6 months ago

just realizing that you doing this development on a fork of the repo makes it harder for me to come in and collaborate on the branch 🤔 probably easier to just create branches in the main repo for now

tibetsprague commented 6 months ago

maybe you can create a PR to a branch in the central repo by the same name? then i can merge into that branch and do my work on that before merging to dev 🤔

tibetsprague commented 6 months ago

eh, for now ill just merge this to dev and add the icons there because im lazy

tibetsprague commented 6 months ago

well i found a bug after merging. if you change the post type of the duplicated post then it loses all the post content, because changing the post type changes the URL and gets rid of the fromPostId= parameter

tibetsprague commented 6 months ago

created ticket https://github.com/Hylozoic/hylo-evo/issues/1610

tibetsprague commented 6 months ago

also duplicating does not copy the images or attachments, which I think it should

tibetsprague commented 6 months ago

https://github.com/Hylozoic/hylo-evo/issues/1611

KevinTriplett commented 6 months ago

Want me to create a branch on the main repo and replicate the PR? I can do that.

Ah -- yah, I caught the missing attachments just today and wondered about it. Okay, thanks, I'll continue with the additional issues.