search

Hylozoic / hylo-evo

Hylo UI
Apache License 2.0
36 stars 10 forks source link

Evo 1564 proposals v1 #1619

Closed thomasgwatson closed 4 months ago

thomasgwatson commented 5 months ago

closes #1564

Screenshot 2024-04-15 at 1 37 48 PM Screenshot 2024-04-11 at 4 46 47 PM Screenshot 2024-04-11 at 4 46 58 PM Screenshot 2024-04-11 at 4 47 13 PM Screenshot 2024-04-11 at 4 47 24 PM Screenshot 2024-04-11 at 4 47 34 PM Screenshot 2024-04-11 at 4 47 43 PM

thomasgwatson commented 5 months ago

Screenshot 2024-05-09 at 6 06 26 PM Screenshot 2024-05-09 at 6 06 51 PM Screenshot 2024-05-09 at 6 07 12 PM Screenshot 2024-05-09 at 6 07 29 PM

An interface for adding proposal outcomes. Visible only to authors.

Once a proposal is 'fulfilled' by its author, they have the option to add a summary.

The outcome display below the quorum bar is visible to all. The same color blue is used for the highest rank votes.

tibetsprague commented 5 months ago

that looks good to me and I am happy to go with it. I thought we had landed on the outcome text just being a pinned comment but once again our notes aren't clear and I am good with this version.

tibetsprague commented 4 months ago

i think this is at a point where we should start testing it on staging, that will be the best way to feel it out and see if we need to make more changes.

thomasgwatson commented 4 months ago

Yeah for sure, lets get it up on staging

On Tue, 14 May 2024 at 22:32, Tibet Sprague @.***> wrote:

i think this is at a point where we should start testing it on staging, that will be the best way to feel it out and see if we need to make more changes.

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2111619161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4ATVU6AARHUALVLQYULZCLXNVAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRGYYTSMJWGE . You are receiving this because you authored the thread.Message ID: @.***>

tibetsprague commented 4 months ago

Trying to create a proposal post on staging errored out

Screenshot 2024-05-16 at 8 45 07 PM

thomasgwatson commented 4 months ago

Can you check the network tab? Any warnings?

On Fri, May 17, 2024, 12:46 Tibet Sprague @.***> wrote:

Trying to create a proposal post on staging errored out

Screenshot.2024-05-16.at.8.45.07.PM.png (view on web) https://github.com/Hylozoic/hylo-evo/assets/3741/b212e8ae-7a03-4d0e-a56a-31651fc33c4d

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116571372, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AS6CO3JSG3ZOFV6BZDZCV4PVAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGU3TCMZXGI . You are receiving this because you authored the thread.Message ID: @.***>

tibetsprague commented 4 months ago

Just said an error in createPost. Staging doesnt show the errors unfortunately.

On May 16, 2024, at 8:50 PM, Tom Watson @.***> wrote:

Can you check the network tab? Any warnings?

On Fri, May 17, 2024, 12:46 Tibet Sprague @.***> wrote:

Trying to create a proposal post on staging errored out

Screenshot.2024-05-16.at.8.45.07.PM.png (view on web) https://github.com/Hylozoic/hylo-evo/assets/3741/b212e8ae-7a03-4d0e-a56a-31651fc33c4d

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116571372, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AS6CO3JSG3ZOFV6BZDZCV4PVAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGU3TCMZXGI . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116574673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HILO7VBTXCG3ZUQWWLZCV5BXAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGU3TINRXGM. You are receiving this because you commented.

thomasgwatson commented 4 months ago

Doing a proposal pretty much like your succeeds in local env but fails in staging. Not the clean debugging situation I would have liked. Can we get into the logs of the staging instance?

Screenshot 2024-05-16 at 11 14 19 PM Screenshot 2024-05-16 at 11 14 29 PM

tibetsprague commented 4 months ago

Do you have Heroku access? You should if you dont

On May 16, 2024, at 11:16 PM, Tom Watson @.***> wrote:

Doing a proposal pretty much like your succeeds in local env but fails in staging. Not the clean debugging situation I would have liked. Can we get into the logs of the staging instance?

Screenshot.2024-05-16.at.11.14.19.PM.jpg (view on web) https://github.com/Hylozoic/hylo-evo/assets/5193218/7309e051-6818-4be5-9336-831f73a6ae43 Screenshot.2024-05-16.at.11.14.29.PM.jpg (view on web) https://github.com/Hylozoic/hylo-evo/assets/5193218/a17645b6-a5cf-4ab9-8ae0-73c677177753 — Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116816007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HP7RDST7ES4DBZRWG3ZCWOEDAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHAYTMMBQG4. You are receiving this because you commented.

thomasgwatson commented 4 months ago

Ahhh I think I do. Sorry, I'll check it out

On Fri, May 17, 2024, 15:59 Tibet Sprague @.***> wrote:

Do you have Heroku access? You should if you dont

On May 16, 2024, at 11:16 PM, Tom Watson @.***> wrote:

Doing a proposal pretty much like your succeeds in local env but fails in staging. Not the clean debugging situation I would have liked. Can we get into the logs of the staging instance?

Screenshot.2024-05-16.at.11.14.19.PM.jpg (view on web) < https://github.com/Hylozoic/hylo-evo/assets/5193218/7309e051-6818-4be5-9336-831f73a6ae43>

Screenshot.2024-05-16.at.11.14.29.PM.jpg (view on web) < https://github.com/Hylozoic/hylo-evo/assets/5193218/a17645b6-a5cf-4ab9-8ae0-73c677177753>

— Reply to this email directly, view it on GitHub < https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116816007>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAA5HP7RDST7ES4DBZRWG3ZCWOEDAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHAYTMMBQG4>.

You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116883499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AXOI7HRWJRWCWN6M2TZCWTGHAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHA4DGNBZHE . You are receiving this because you authored the thread.Message ID: @.***>

tibetsprague commented 4 months ago

Also I can try to update the database from prod in the morning if we cant figure out whats up. But could be some production setting that is different from local. An environment variable?

On May 17, 2024, at 12:02 AM, Tom Watson @.***> wrote:

Ahhh I think I do. Sorry, I'll check it out

On Fri, May 17, 2024, 15:59 Tibet Sprague @.***> wrote:

Do you have Heroku access? You should if you dont

On May 16, 2024, at 11:16 PM, Tom Watson @.***> wrote:

Doing a proposal pretty much like your succeeds in local env but fails in staging. Not the clean debugging situation I would have liked. Can we get into the logs of the staging instance?

Screenshot.2024-05-16.at.11.14.19.PM.jpg (view on web) < https://github.com/Hylozoic/hylo-evo/assets/5193218/7309e051-6818-4be5-9336-831f73a6ae43>

Screenshot.2024-05-16.at.11.14.29.PM.jpg (view on web) < https://github.com/Hylozoic/hylo-evo/assets/5193218/a17645b6-a5cf-4ab9-8ae0-73c677177753>

— Reply to this email directly, view it on GitHub < https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116816007>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAA5HP7RDST7ES4DBZRWG3ZCWOEDAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHAYTMMBQG4>.

You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116883499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AXOI7HRWJRWCWN6M2TZCWTGHAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHA4DGNBZHE . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116887171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA5HNRQWATLAEIZVKDZPTZCWTQTAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHA4DOMJXGE. You are receiving this because you commented.

thomasgwatson commented 4 months ago

I don't think I've added or changed any env variables. I'll have a dig later, heading out

On Fri, May 17, 2024, 16:18 Tibet Sprague @.***> wrote:

Also I can try to update the database from prod in the morning if we cant figure out whats up. But could be some production setting that is different from local. An environment variable?

On May 17, 2024, at 12:02 AM, Tom Watson @.***> wrote:

Ahhh I think I do. Sorry, I'll check it out

On Fri, May 17, 2024, 15:59 Tibet Sprague @.***> wrote:

Do you have Heroku access? You should if you dont

On May 16, 2024, at 11:16 PM, Tom Watson @.***> wrote:

Doing a proposal pretty much like your succeeds in local env but fails in staging. Not the clean debugging situation I would have liked. Can we get into the logs of the staging instance?

Screenshot.2024-05-16.at.11.14.19.PM.jpg (view on web) <

https://github.com/Hylozoic/hylo-evo/assets/5193218/7309e051-6818-4be5-9336-831f73a6ae43>

Screenshot.2024-05-16.at.11.14.29.PM.jpg (view on web) <

https://github.com/Hylozoic/hylo-evo/assets/5193218/a17645b6-a5cf-4ab9-8ae0-73c677177753>

— Reply to this email directly, view it on GitHub < https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116816007>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAAA5HP7RDST7ES4DBZRWG3ZCWOEDAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHAYTMMBQG4>.

You are receiving this because you commented.

— Reply to this email directly, view it on GitHub < https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116883499>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABHT4AXOI7HRWJRWCWN6M2TZCWTGHAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHA4DGNBZHE>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116887171>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAA5HNRQWATLAEIZVKDZPTZCWTQTAVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHA4DOMJXGE>.

You are receiving this because you commented.

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2116909943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4AQNMUMNWORX274WTEDZCWVM5AVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHEYDSOJUGM . You are receiving this because you authored the thread.Message ID: @.***>

thomasgwatson commented 4 months ago

Well, the logs are unfortunately completely uninteresting.

No error message. GraphQL log seems to be fine... I will note there are no SQL queries that come after it, so I imagine its something happening before the database is hit

Screenshot 2024-05-17 at 4 06 16 PM

Screenshot 2024-05-17 at 4 06 07 PM

2024-05-18T00:20:23.921658+00:00 app[web.1]: graphql query start

2024-05-18T00:20:23.921663+00:00 app[web.1]: mutation (

2024-05-18T00:20:23.921664+00:00 app[web.1]:   $acceptContributions: Boolean,

2024-05-18T00:20:23.921664+00:00 app[web.1]:   $announcement: Boolean,

2024-05-18T00:20:23.921665+00:00 app[web.1]:   $details: String,

2024-05-18T00:20:23.921665+00:00 app[web.1]:   $donationsLink: String,

2024-05-18T00:20:23.921665+00:00 app[web.1]:   $endTime: Date,

2024-05-18T00:20:23.921666+00:00 app[web.1]:   $eventInviteeIds: [ID],

2024-05-18T00:20:23.921666+00:00 app[web.1]:   $fileUrls: [String],

2024-05-18T00:20:23.921666+00:00 app[web.1]:   $groupIds: [ID],

2024-05-18T00:20:23.921667+00:00 app[web.1]:   $imageUrls: [String],

2024-05-18T00:20:23.921667+00:00 app[web.1]:   $isAnonymousVote: Boolean,

2024-05-18T00:20:23.921667+00:00 app[web.1]:   $isPublic: Boolean,

2024-05-18T00:20:23.921667+00:00 app[web.1]:   $isStrictProposal: Boolean,

2024-05-18T00:20:23.921667+00:00 app[web.1]:   $linkPreviewFeatured: Boolean,

2024-05-18T00:20:23.921668+00:00 app[web.1]:   $linkPreviewId: String,

2024-05-18T00:20:23.921668+00:00 app[web.1]:   $location: String,

2024-05-18T00:20:23.921668+00:00 app[web.1]:   $locationId: ID,

2024-05-18T00:20:23.921668+00:00 app[web.1]:   $memberIds: [ID],

2024-05-18T00:20:23.921668+00:00 app[web.1]:   $projectManagementLink: String,

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $proposalOptions: [ProposalOptionInput],

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $proposalType: String,

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $quorum: Int,

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $startTime: Date,

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $timezone: String,

2024-05-18T00:20:23.921669+00:00 app[web.1]:   $title: String,

2024-05-18T00:20:23.921670+00:00 app[web.1]:   $topicNames: [String],

2024-05-18T00:20:23.921670+00:00 app[web.1]:   $type: String,

2024-05-18T00:20:23.921670+00:00 app[web.1]: ) {

2024-05-18T00:20:23.921670+00:00 app[web.1]:   createPost(data: {

2024-05-18T00:20:23.921670+00:00 app[web.1]:     acceptContributions: $acceptContributions,

2024-05-18T00:20:23.921671+00:00 app[web.1]:     announcement: $announcement,

2024-05-18T00:20:23.921671+00:00 app[web.1]:     details: $details,

2024-05-18T00:20:23.921671+00:00 app[web.1]:     donationsLink: $donationsLink,

2024-05-18T00:20:23.921671+00:00 app[web.1]:     endTime: $endTime,

2024-05-18T00:20:23.921672+00:00 app[web.1]:     eventInviteeIds: $eventInviteeIds,

2024-05-18T00:20:23.921672+00:00 app[web.1]:     fileUrls: $fileUrls,

2024-05-18T00:20:23.921685+00:00 app[web.1]:     groupIds: $groupIds,

2024-05-18T00:20:23.921685+00:00 app[web.1]:     imageUrls: $imageUrls,

2024-05-18T00:20:23.921685+00:00 app[web.1]:     isAnonymousVote: $isAnonymousVote,

2024-05-18T00:20:23.921685+00:00 app[web.1]:     isPublic: $isPublic,

2024-05-18T00:20:23.921686+00:00 app[web.1]:     isStrictProposal: $isStrictProposal,

2024-05-18T00:20:23.921686+00:00 app[web.1]:     linkPreviewFeatured: $linkPreviewFeatured,

2024-05-18T00:20:23.921686+00:00 app[web.1]:     linkPreviewId: $linkPreviewId,

2024-05-18T00:20:23.921686+00:00 app[web.1]:     location: $location,

2024-05-18T00:20:23.921687+00:00 app[web.1]:     locationId: $locationId,

2024-05-18T00:20:23.921687+00:00 app[web.1]:     memberIds: $memberIds,

2024-05-18T00:20:23.921688+00:00 app[web.1]:     projectManagementLink: $projectManagementLink,

2024-05-18T00:20:23.921689+00:00 app[web.1]:     proposalOptions: $proposalOptions,

2024-05-18T00:20:23.921689+00:00 app[web.1]:     proposalType: $proposalType,

2024-05-18T00:20:23.921689+00:00 app[web.1]:     quorum: $quorum,

2024-05-18T00:20:23.921689+00:00 app[web.1]:     startTime: $startTime,

2024-05-18T00:20:23.921689+00:00 app[web.1]:     timezone: $timezone,

2024-05-18T00:20:23.921690+00:00 app[web.1]:     title: $title,

2024-05-18T00:20:23.921690+00:00 app[web.1]:     topicNames: $topicNames,

2024-05-18T00:20:23.921690+00:00 app[web.1]:     type: $type,

2024-05-18T00:20:23.921690+00:00 app[web.1]:   }) {

2024-05-18T00:20:23.921690+00:00 app[web.1]:   id

2024-05-18T00:20:23.921690+00:00 app[web.1]:   announcement

2024-05-18T00:20:23.921691+00:00 app[web.1]:   title

2024-05-18T00:20:23.921691+00:00 app[web.1]:   details

2024-05-18T00:20:23.921691+00:00 app[web.1]:   type

2024-05-18T00:20:23.921691+00:00 app[web.1]:   creator {

2024-05-18T00:20:23.921691+00:00 app[web.1]:     id

2024-05-18T00:20:23.921691+00:00 app[web.1]:     name

2024-05-18T00:20:23.921691+00:00 app[web.1]:     avatarUrl

2024-05-18T00:20:23.921692+00:00 app[web.1]:     groupRoles {

2024-05-18T00:20:23.921692+00:00 app[web.1]:       name

2024-05-18T00:20:23.921692+00:00 app[web.1]:       emoji

2024-05-18T00:20:23.921692+00:00 app[web.1]:       active

2024-05-18T00:20:23.921692+00:00 app[web.1]:       groupId

2024-05-18T00:20:23.921692+00:00 app[web.1]:     }

2024-05-18T00:20:23.921692+00:00 app[web.1]:     moderatedGroupMemberships {

2024-05-18T00:20:23.921693+00:00 app[web.1]:       groupId

2024-05-18T00:20:23.921694+00:00 app[web.1]:     }

2024-05-18T00:20:23.921694+00:00 app[web.1]:   }

2024-05-18T00:20:23.921694+00:00 app[web.1]:   createdAt

2024-05-18T00:20:23.921694+00:00 app[web.1]:   updatedAt

2024-05-18T00:20:23.921694+00:00 app[web.1]:   isAnonymousVote

2024-05-18T00:20:23.921694+00:00 app[web.1]:   isPublic

2024-05-18T00:20:23.921694+00:00 app[web.1]:   fulfilledAt

2024-05-18T00:20:23.921695+00:00 app[web.1]:   startTime

2024-05-18T00:20:23.921695+00:00 app[web.1]:   endTime

2024-05-18T00:20:23.921695+00:00 app[web.1]:   timezone

2024-05-18T00:20:23.921695+00:00 app[web.1]:   donationsLink

2024-05-18T00:20:23.921695+00:00 app[web.1]:   projectManagementLink

2024-05-18T00:20:23.921695+00:00 app[web.1]:   myEventResponse

2024-05-18T00:20:23.921696+00:00 app[web.1]:   commenters(first: 3) {

2024-05-18T00:20:23.921696+00:00 app[web.1]:     id

2024-05-18T00:20:23.921696+00:00 app[web.1]:     name

2024-05-18T00:20:23.921696+00:00 app[web.1]:     avatarUrl

2024-05-18T00:20:23.921697+00:00 app[web.1]:   }

2024-05-18T00:20:23.921697+00:00 app[web.1]:   commentersTotal

2024-05-18T00:20:23.921697+00:00 app[web.1]:   commentsTotal

2024-05-18T00:20:23.921698+00:00 app[web.1]:   

2024-05-18T00:20:23.921698+00:00 app[web.1]:   linkPreview {

2024-05-18T00:20:23.921698+00:00 app[web.1]:     description

2024-05-18T00:20:23.921698+00:00 app[web.1]:     id

2024-05-18T00:20:23.921698+00:00 app[web.1]:     imageUrl

2024-05-18T00:20:23.921699+00:00 app[web.1]:     title

2024-05-18T00:20:23.921699+00:00 app[web.1]:     url

2024-05-18T00:20:23.921699+00:00 app[web.1]:   }

2024-05-18T00:20:23.921699+00:00 app[web.1]:   linkPreviewFeatured

2024-05-18T00:20:23.921699+00:00 app[web.1]:   location

2024-05-18T00:20:23.921699+00:00 app[web.1]:   locationObject {

2024-05-18T00:20:23.921699+00:00 app[web.1]:     id

2024-05-18T00:20:23.921700+00:00 app[web.1]:     addressNumber

2024-05-18T00:20:23.921700+00:00 app[web.1]:     addressStreet

2024-05-18T00:20:23.921700+00:00 app[web.1]:     bbox {

2024-05-18T00:20:23.921700+00:00 app[web.1]:       lat

2024-05-18T00:20:23.921700+00:00 app[web.1]:       lng

2024-05-18T00:20:23.921700+00:00 app[web.1]:     }

2024-05-18T00:20:23.921700+00:00 app[web.1]:     center {

2024-05-18T00:20:23.921700+00:00 app[web.1]:       lat

2024-05-18T00:20:23.921701+00:00 app[web.1]:       lng

2024-05-18T00:20:23.921701+00:00 app[web.1]:     }

2024-05-18T00:20:23.921701+00:00 app[web.1]:     city

2024-05-18T00:20:23.921701+00:00 app[web.1]:     country

2024-05-18T00:20:23.921701+00:00 app[web.1]:     fullText

2024-05-18T00:20:23.921701+00:00 app[web.1]:     locality

2024-05-18T00:20:23.921702+00:00 app[web.1]:     neighborhood

2024-05-18T00:20:23.921702+00:00 app[web.1]:     region

2024-05-18T00:20:23.921702+00:00 app[web.1]:   }

2024-05-18T00:20:23.921702+00:00 app[web.1]:   peopleReactedTotal

2024-05-18T00:20:23.921702+00:00 app[web.1]:   proposalStatus

2024-05-18T00:20:23.921702+00:00 app[web.1]:   proposalOutcome

2024-05-18T00:20:23.921702+00:00 app[web.1]:   proposalType

2024-05-18T00:20:23.921703+00:00 app[web.1]:   quorum

2024-05-18T00:20:23.921703+00:00 app[web.1]:   proposalOptions {

2024-05-18T00:20:23.921703+00:00 app[web.1]:     total

2024-05-18T00:20:23.921703+00:00 app[web.1]:     hasMore

2024-05-18T00:20:23.921703+00:00 app[web.1]:     items {

2024-05-18T00:20:23.921703+00:00 app[web.1]:       id

2024-05-18T00:20:23.921703+00:00 app[web.1]:       text

2024-05-18T00:20:23.921704+00:00 app[web.1]:       emoji

2024-05-18T00:20:23.921704+00:00 app[web.1]:     }

2024-05-18T00:20:23.921704+00:00 app[web.1]:   }

2024-05-18T00:20:23.921704+00:00 app[web.1]:   proposalVotes {

2024-05-18T00:20:23.921704+00:00 app[web.1]:       total

2024-05-18T00:20:23.921704+00:00 app[web.1]:       hasMore

2024-05-18T00:20:23.921704+00:00 app[web.1]:       items {

2024-05-18T00:20:23.921705+00:00 app[web.1]:         id

2024-05-18T00:20:23.921705+00:00 app[web.1]:         optionId

2024-05-18T00:20:23.921705+00:00 app[web.1]:         user {

2024-05-18T00:20:23.921705+00:00 app[web.1]:           id

2024-05-18T00:20:23.921705+00:00 app[web.1]:           name

2024-05-18T00:20:23.921705+00:00 app[web.1]:           avatarUrl

2024-05-18T00:20:23.921705+00:00 app[web.1]:         }

2024-05-18T00:20:23.921706+00:00 app[web.1]:       }

2024-05-18T00:20:23.921706+00:00 app[web.1]:   }

2024-05-18T00:20:23.921706+00:00 app[web.1]:   myReactions {

2024-05-18T00:20:23.921706+00:00 app[web.1]:     emojiFull

2024-05-18T00:20:23.921706+00:00 app[web.1]:     id

2024-05-18T00:20:23.921706+00:00 app[web.1]:   }

2024-05-18T00:20:23.921706+00:00 app[web.1]:   postReactions {

2024-05-18T00:20:23.921707+00:00 app[web.1]:     emojiFull

2024-05-18T00:20:23.921707+00:00 app[web.1]:     id

2024-05-18T00:20:23.921707+00:00 app[web.1]:     user {

2024-05-18T00:20:23.921707+00:00 app[web.1]:       id

2024-05-18T00:20:23.921707+00:00 app[web.1]:       name

2024-05-18T00:20:23.921707+00:00 app[web.1]:     }

2024-05-18T00:20:23.921707+00:00 app[web.1]:   }

2024-05-18T00:20:23.921708+00:00 app[web.1]:   groups {

2024-05-18T00:20:23.921708+00:00 app[web.1]:     id

2024-05-18T00:20:23.921708+00:00 app[web.1]:     name

2024-05-18T00:20:23.921708+00:00 app[web.1]:     slug

2024-05-18T00:20:23.921708+00:00 app[web.1]:   }

2024-05-18T00:20:23.921708+00:00 app[web.1]:   attachments {

2024-05-18T00:20:23.921708+00:00 app[web.1]:     type

2024-05-18T00:20:23.921709+00:00 app[web.1]:     url

2024-05-18T00:20:23.921709+00:00 app[web.1]:     position

2024-05-18T00:20:23.921709+00:00 app[web.1]:     id

2024-05-18T00:20:23.921710+00:00 app[web.1]:   }

2024-05-18T00:20:23.921710+00:00 app[web.1]:   postMemberships {

2024-05-18T00:20:23.921710+00:00 app[web.1]:     id

2024-05-18T00:20:23.921710+00:00 app[web.1]:     pinned

2024-05-18T00:20:23.921711+00:00 app[web.1]:     group {

2024-05-18T00:20:23.921711+00:00 app[web.1]:       id

2024-05-18T00:20:23.921711+00:00 app[web.1]:     }

2024-05-18T00:20:23.921711+00:00 app[web.1]:   }

2024-05-18T00:20:23.921711+00:00 app[web.1]:   topics {

2024-05-18T00:20:23.921712+00:00 app[web.1]:     id

2024-05-18T00:20:23.921712+00:00 app[web.1]:     name

2024-05-18T00:20:23.921712+00:00 app[web.1]:   }

2024-05-18T00:20:23.921712+00:00 app[web.1]:   members {

2024-05-18T00:20:23.921712+00:00 app[web.1]:     total

2024-05-18T00:20:23.921712+00:00 app[web.1]:     hasMore

2024-05-18T00:20:23.921713+00:00 app[web.1]:     items {

2024-05-18T00:20:23.921713+00:00 app[web.1]:       id

2024-05-18T00:20:23.921713+00:00 app[web.1]:       name

2024-05-18T00:20:23.921713+00:00 app[web.1]:       avatarUrl

2024-05-18T00:20:23.921713+00:00 app[web.1]:       bio

2024-05-18T00:20:23.921714+00:00 app[web.1]:       tagline

2024-05-18T00:20:23.921714+00:00 app[web.1]:       location

2024-05-18T00:20:23.921714+00:00 app[web.1]:     }

2024-05-18T00:20:23.921714+00:00 app[web.1]:   }

2024-05-18T00:20:23.921714+00:00 app[web.1]:   eventInvitations {

2024-05-18T00:20:23.921714+00:00 app[web.1]:     total

2024-05-18T00:20:23.921714+00:00 app[web.1]:     hasMore

2024-05-18T00:20:23.921715+00:00 app[web.1]:     items {

2024-05-18T00:20:23.921715+00:00 app[web.1]:       id

2024-05-18T00:20:23.921715+00:00 app[web.1]:       response

2024-05-18T00:20:23.921715+00:00 app[web.1]:       person {

2024-05-18T00:20:23.921715+00:00 app[web.1]:         id

2024-05-18T00:20:23.921715+00:00 app[web.1]:         name

2024-05-18T00:20:23.921715+00:00 app[web.1]:         avatarUrl

2024-05-18T00:20:23.921715+00:00 app[web.1]:         bio

2024-05-18T00:20:23.921716+00:00 app[web.1]:         tagline

2024-05-18T00:20:23.921716+00:00 app[web.1]:         location

2024-05-18T00:20:23.921716+00:00 app[web.1]:       }

2024-05-18T00:20:23.921716+00:00 app[web.1]:     }

2024-05-18T00:20:23.921716+00:00 app[web.1]:   }

2024-05-18T00:20:23.921716+00:00 app[web.1]: }

2024-05-18T00:20:23.921716+00:00 app[web.1]: }

2024-05-18T00:20:23.921717+00:00 app[web.1]: graphql query end

2024-05-18T00:20:23.922733+00:00 app[web.1]:  info: {

2024-05-18T00:20:23.922734+00:00 app[web.1]:   acceptContributions: false,

2024-05-18T00:20:23.922734+00:00 app[web.1]:   details: '<p>meep</p>',

2024-05-18T00:20:23.922734+00:00 app[web.1]:   donationsLink: null,

2024-05-18T00:20:23.922734+00:00 app[web.1]:   eventInviteeIds: [],

2024-05-18T00:20:23.922735+00:00 app[web.1]:   fileUrls: [],

2024-05-18T00:20:23.922735+00:00 app[web.1]:   groupIds: [ '20820' ],

2024-05-18T00:20:23.922735+00:00 app[web.1]:   imageUrls: [],

2024-05-18T00:20:23.922735+00:00 app[web.1]:   isAnonymousVote: false,

2024-05-18T00:20:23.922736+00:00 app[web.1]:   isPublic: false,

2024-05-18T00:20:23.922736+00:00 app[web.1]:   isStrictProposal: false,

2024-05-18T00:20:23.922736+00:00 app[web.1]:   location: null,

2024-05-18T00:20:23.922736+00:00 app[web.1]:   memberIds: [],

2024-05-18T00:20:23.922736+00:00 app[web.1]:   projectManagementLink: null,

2024-05-18T00:20:23.922736+00:00 app[web.1]:   proposalOptions: [

2024-05-18T00:20:23.922736+00:00 app[web.1]:     { text: 'Yes', emoji: '👍', color: '' },

2024-05-18T00:20:23.922737+00:00 app[web.1]:     { text: 'No', emoji: '👎', color: '' }

2024-05-18T00:20:23.922737+00:00 app[web.1]:   ],

2024-05-18T00:20:23.922737+00:00 app[web.1]:   proposalType: 'single',

2024-05-18T00:20:23.922737+00:00 app[web.1]:   quorum: 25,

2024-05-18T00:20:23.922737+00:00 app[web.1]:   timezone: 'America/Los_Angeles',

2024-05-18T00:20:23.922737+00:00 app[web.1]:   title: 'meep',

2024-05-18T00:20:23.922737+00:00 app[web.1]:   topicNames: [],

2024-05-18T00:20:23.922738+00:00 app[web.1]:   type: 'proposal'

2024-05-18T00:20:23.922738+00:00 app[web.1]: }

2024-05-18T00:20:23.927434+00:00 app[web.1]:  info: 2.650ms update "users" set "last_active_at" = "2024-05-18T00:20:23.922Z"

2024-05-18T00:20:23.927435+00:00 app[web.1]: WHERE "id" = 30623

2024-05-18T00:20:23.933561+00:00 app[web.1]:  info: 2.916ms SELECT "groups"."id",

2024-05-18T00:20:23.933562+00:00 app[web.1]:      "groups"."id"

2024-05-18T00:20:23.933563+00:00 app[web.1]: FROM "group_memberships"

2024-05-18T00:20:23.933564+00:00 app[web.1]: INNER JOIN "groups"

2024-05-18T00:20:23.933564+00:00 app[web.1]:   ON "groups"."id" = "group_memberships"."group_id"

2024-05-18T00:20:23.933564+00:00 app[web.1]: WHERE "group_memberships"."user_id" = 30623

2024-05-18T00:20:23.933565+00:00 app[web.1]:     AND "group_memberships"."active" = true

2024-05-18T00:20:23.933565+00:00 app[web.1]:     AND "groups"."active" = true

2024-05-18T00:20:23.979740+00:00 heroku[router]: at=info method=POST path="/noo/graphql" host=api-staging.hylo.com request_id=983633e8-b24e-4326-bdfa-9d8a7b0126ae fwd="125.30.91.55,35.173.57.145" dyno=web.1 connect=0ms service=161ms status=200 bytes=419 protocol=https

2024-05-18T00:29:57.494715+00:00 app[web.1]:  info: Websockets: join: groups/20866
tibetsprague commented 4 months ago

Starting to put in feedback/requests from testing: #1) Quorum should show the number of people that the percentage represents. Though this could be tricky if multiple groups are selected... hmm what do we do with quorum if multiple groups are selected??

tibetsprague commented 4 months ago

Seeing all kinds of weird behavior if i select a template then delete all the options and then select a different template. Actually selecting templates only seems to work sometimes, not sure why. Certain templates work more often than others. I think maybe we need to walk through all the templates as a group and decide what they do. For example I dont know about Poll changing the post title. Also consent doesnt necessarily mean quorom = 100%, it normally means no blocks among the quorum, which could even be 0. Just no one blocks over a certain period of time.

thomasgwatson commented 4 months ago

Are there specific conditions you can recreate that trigger the weird behavior with templates? I just whipped down the list of them, selecting each and then deleting all the options and it worked as I expected it.

Certainly, until we add 'weights' to options (or otherwise make 'block' or 'veto' magic options), there are a few templates that don't truly represent what they are called. All the quorums are suggestions, you can change them all you like. Similarly, poll going into the title is just a suggestion.

Quorum for multiple groups does add up all the membership numbers for all the groups.

const calcNumberOfPossibleVoters = (groups) => { return groups.reduce((acc, group) => { return acc + group.memberCount }, 0) }

I would say it's rare that a multiple group quorum would make sense but it's possible that it could.

On Wed, 22 May 2024 at 11:03, Tibet Sprague @.***> wrote:

Seeing all kinds of weird behavior if i select a template then delete all the options and then select a different template. Actually selecting templates only seems to work sometimes, not sure why. Certain templates work more often than others. I think maybe we need to walk through all the templates as a group and decide what they do. For example I dont know about Poll changing the post title. Also consent doesnt necessarily mean quorom = 100%, it normally means no blocks among the quorum, which could even be 0. Just no one blocks over a certain period of time.

— Reply to this email directly, view it on GitHub https://github.com/Hylozoic/hylo-evo/pull/1619#issuecomment-2125440423, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHT4ASOLAL7MPKDG3SAQS3ZDTMX7AVCNFSM6AAAAABGKBC3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGQ2DANBSGM . You are receiving this because you authored the thread.Message ID: @.***>

tibetsprague commented 4 months ago

undoing proposal complete should remove the outcome (i think?) but probably have a warning alert first

tibetsprague commented 4 months ago

if proposal is complete, votes should not be able to be changed

tibetsprague commented 4 months ago

governance view showing all post types right now. also remove the post type dropdown

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 25.08591% with 218 lines in your changes missing coverage. Please review.

Project coverage is 47.11%. Comparing base (6ecaf5d) to head (dd8b7a1). Report is 12 commits behind head on dev.

Files Patch % Lines
src/components/PostEditor/PostEditor.js 22.98% 67 Missing :warning:
...ents/PostCard/PostBodyProposal/PostBodyProposal.js 5.79% 65 Missing :warning:
src/store/reducers/ormReducer/index.js 0.00% 37 Missing :warning:
...ditor/StrictProposalToggle/StrictProposalToggle.js 0.00% 8 Missing :warning:
src/components/QuorumBar/QuorumBar.js 11.11% 8 Missing :warning:
src/util/generateTempId.js 0.00% 7 Missing :warning:
src/store/actions/proposals/index.js 0.00% 6 Missing :warning:
...tEditor/AnonymousVoteToggle/AnonymousVoteToggle.js 37.50% 5 Missing :warning:
src/components/SliderInput/SliderInput.js 16.66% 5 Missing :warning:
src/components/PostCard/PostHeader/PostHeader.js 57.14% 3 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1619 +/- ## ========================================== - Coverage 47.73% 47.11% -0.62% ========================================== Files 569 574 +5 Lines 13448 13705 +257 Branches 3867 3949 +82 ========================================== + Hits 6419 6457 +38 - Misses 7029 7248 +219 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.