Hylozoic / hylo-evo

Hylo UI
Apache License 2.0
36 stars 10 forks source link

Evo 1654 add modal keyboard events handling #1657

Closed KevinTriplett closed 1 month ago

KevinTriplett commented 1 month ago

fixes #1654

Problems:

Three commits:

Best I could do quickly -- may have been a cleaner way to do it but eh

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.23%. Comparing base (9a96a7a) to head (757ca1f). Report is 32 commits behind head on dev.

Files Patch % Lines
src/components/ImageCarousel/ImageCarousel.js 69.23% 4 Missing :warning:
src/components/ModalDialog/ModalDialog.js 75.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1657 +/- ## ========================================== + Coverage 47.17% 47.23% +0.05% ========================================== Files 575 575 Lines 13723 13748 +25 Branches 3958 3964 +6 ========================================== + Hits 6474 6494 +20 - Misses 7249 7254 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KevinTriplett commented 1 month ago

I'm looking at tests I can add to improve coverage and catch future regressions