search

Hylozoic / hylo

2 stars 0 forks source link

Clicking on comment notifications scrolls to that comment #35

Open tibetsprague opened 2 years ago

tibetsprague commented 2 years ago

The comment should flash or be highlighted.

lorenjohnson commented 1 year ago

Note to self: A bit differently than was implemented on Web, I think in the App I'll show only the Post and the Comment linked to (as well as it's parent comment if there is one), and reply upon the pagination information to generate the "X more comments" links surrounding those entries. We'll see once I get into implementing if what I have available on our API makes this actually simpler, but I think it will. This is what Facebook does in these cases.

lorenjohnson commented 1 year ago

@thomasgwatson My above note to self is now a note to you. I think for a better UX the above implementation suggestion would be better. Just load the post and to single comment utilising the existing functionality for "X more comments" links above and below the comment displayed. Last I checked this is what Facebook was doing on both Web and their App, but who knows if they aren't doing something different by now. Either way, I think doing it that way will get snappy and keep us out of trouble on long comment threads.

thomasgwatson commented 1 year ago

Right. Makes sense, and I'll cut a separate ticket for it

lorenjohnson commented 1 year ago

I think if you do this it should do away with scrolling delay and otherwise address the other issue you were having?