search

Hylozoic / hylo

2 stars 0 forks source link

Switch from Moment to Luxon #65

Open tibetsprague opened 2 years ago

tibetsprague commented 2 years ago

This reduces bundle size and gives us built in browser timezone and internationalization support https://moment.github.io/luxon/#/tour

lorenjohnson commented 2 years ago

Yes! We should do already have TZ support with moment-tz but definitely a fan of moving to Luxon for the smaller bundle and it sounds like it may be necessary for the internationalization. It's a thing we need to do on all platform at once. The dependencies need to upgrade in the backend, Web and App, and then peerDependencies needs to update on shared. They should all be version aligned.

Also: Much of the internationalization stuff should be put into shared as well, so all the more reason it would be best to figure-out how to best get that into a monorepo setup with hylo-evo sooner than later...