Closed gnardin closed 1 year ago
ready for merge. @gnardin ?
Yes, it is ready to merge. Should I merge using "Merge pull request" (include all commits), "Squash and merge" (squash the commits in 1) or "Rebase and merge"?
definetely not "rebase"
The Golden Rule of Git Rebase Since git rebase command essentially re-writes git history, it should never be used on a branch which is shared with another developer (Unless both developers are kind of git experts). Or as its also said, never use the rebasing for public branches.
I'm unsure we decided which of the other two options is preferred in this repo.
I'd say: because you authored most of the commits, squashing is ok because it woudn't "erase" other's contributions.
This is the first draft of the motivating scenario introducing the term hmas:Organization and the properties hmas:isMemberOf and hmas:isMaterialOf.