Open NicoRobertIn opened 1 year ago
After an approbation of @FabienGandon , a first version of the script is published on the branch test-workflow
Excellent. Thanks Nico !
Can I create a test-scenario branch to commit my work?
It could be useful to add some "Common sense" tests, what other examples than below can you imagine e.g. :
example of "Common sense" test (proposed by @FabienGandon): a property has a domain or range that is not defined in the ontology
a same instance belongs to two different classes ?
similar names for properties/ classes ?
violation of SHACL constraints ?
...
For meta.ttl, if we continue to work on this ontology, it could be benefit to add warning messages like :
It is just naive ideas.
I just commited to add the asked features
I pushed an example of what a report looks like (for now, WIP), and also added some mistakes in the ontology ON PURPOSE (you are all doing your job so well that I have to add errors myself)
example of "Common sense" test (proposed by @FabienGandon): a property has a domain or range that is not defined in the ontology
a same instance belongs to two different classes ?
similar names for properties/ classes ?
For meta.ttl, if we continue to work on this ontology, it could be benefit to add warning messages
I just also added a best practices check on ontology terms based on levenshtein distance By default the threshold is put to 3 but this is just a parameter
The last heartbeat meeting showed the following points:
This bug was not a bug. The property hosts and isHostedOn still have respectedly a range and a domain set to hmas:Hostable This term is not considered useful anymore and is therefore not implemented. Since this is still in the modelet in domains/manufacturing-environments/discover-platforms it means that is will be in the fully merged graph (modules + modelets) and therefore raised an error in the global report
To make it more clear, I changed a little bit the request and message error to detect more easily this case in the report:
The property isHostedOn has a domain out of the ontology: <https://purl.org/hmas/Hostable>
More recent news:
@NicoRobertIn : I believe that following the last heartbeat meeting we agreed to merge the script branch with the master and we could close that issue and copy some of its content to the documentation where needed.
Just for the other ones who were not there at the heartbeat meeting, I made a markdown export of the test report that can be seen there: https://github.com/HyperAgents/hmas/blob/test-workflow/.acimov/output/actions.md
I am currently making it compatible with pre-commit and eventually would like to finish this before the plenary meeting Once it is done I will propose a pull request
These last 2 days I extended a script @DrLeturc made to check the health of the ontology. It uses the Corese python library with py4j.
My questions
Keep in mind: this is WIP, especially the format (issues will be posted in Corese repository to have some structured error reports)
What the script does
Here is a small portion of the output, given the project state 2 days ago: