Closed vcharpenay closed 1 year ago
excellent, well done !
in the scenario folders, the recommendations header could be a level higher, because it seems as a sub-section in the glossary section.
That's all I see for the moment.
In the Glossary section of the scenario README.md
file, the term modelet is used. The link to another scenario still points to ../other-feature/modelet.md
instead of ../other-scenario/README.md
.
@gnardin thanks, see last commit to fix the issue you raised.
@maximelefrancois86 the Recommendations header was intentionally put under Glossary, as recommendations apply to the terms introduced in the scenario. But I don't mind putting it one level up. Any other opinion on that?
I'm gonna include my script to check OWL profile with CORESE in the next PR if anyone agrees with this.
@vcharpenay : can you merge the pull request ?
@vcharpenay : now everyone approved the PR, can you merge it, please ?
The new repository structure has been implemented as discussed in plenary. Changes are ready for review.
Note: some tests are still missing (satisfiability, term redundancy) but ontology engineering work can be conducted in parallel, as the template is (hopefully) consistent.