search

HyperPlay-Gaming / hyperplay-desktop-client

The HyperPlay desktop app
https://hyperplay.xyz
GNU General Public License v3.0
67 stars 25 forks source link

Missing confirmation message when using Microsoft SSO to login to Epic Store (Epic Games Login option) #199

Open maxbidding opened 1 year ago

maxbidding commented 1 year ago

Describe the bug

Login worked after a restart, however the message was confusing for the user. See below (token redacted for privacy)

{"redirectUrl":"https://localhost/launcher/authorized?code= }

Add logs

(12:52:46) INFO: [Backend]: Loading MetaMask extension (12:52:46) INFO: [Connection]: Connectivity: check-online (12:52:46) INFO: [Connection]: Pinging external endpoints (12:52:46) INFO: [Backend]: Creating abort controller for legendary-version (12:52:46) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version (12:52:47) INFO: [Legendary]: Legendary location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary (12:52:47) INFO: [Gog]: GOGDL location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl (12:52:47) INFO: [Gog]: GOGDL location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl (12:52:47) INFO: [Backend]: MetaMask extension loaded (12:52:47) WARNING: [Backend]: Protocol already registered. (12:52:47) INFO: [Connection]: Connectivity: online (12:52:47) INFO: [Backend]: User Not Found, removing it from Store (12:52:47) INFO: [Backend]: Deleting abort controller for legendary-version (12:52:47) INFO: [Backend]: Creating abort controller for gogdl-version (12:52:47) INFO: [Gog]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --version (12:52:48) INFO: [Backend]: Deleting abort controller for gogdl-version (12:52:48) INFO: [Backend]: Auto Updater found version: 0.0.9 released on 2023-03-09T00:48:09.445Z with name 0.0.9 (12:52:48) INFO: [Backend]: Loading Screen Ready (12:52:48) INFO: [Backend]: Frontend Ready (12:52:52) INFO: [Backend]:

HyperPlay Version: 0.0.9 Legendary Version: 0.20.32 Dark Energy (hotfix #6) GOGdl Version: 0.6 OS: Microsoft Windows 11 Home KERNEL: 10.0.22621 ARCH: x64 CPU: Intel Core™ i7-8750H @2.2 RAM: Total: 31.88 GiB Available: 24.31 GiB GRAPHICS: GPU0: NVIDIA GeForce RTX 2070 with Max-Q Design VRAM: 8192MB DRIVER: 531.18

(12:52:53) INFO: [Backend]: Starting the Download Queue

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Expected behavior

UI message confirming the login

Screenshots

No response

hyperplay Version

Latest Stable

System Information

Additional information

No response

maxbidding commented 1 year ago

Update: I don't believe the authentication worked, despite the UI message. When trying to download a game from Epic Store, I was prompted to sign in again.

Screenshot 2023-03-14 132150

(12:52:46) INFO: [Backend]: Loading MetaMask extension (12:52:46) INFO: [Connection]: Connectivity: check-online (12:52:46) INFO: [Connection]: Pinging external endpoints (12:52:46) INFO: [Backend]: Creating abort controller for legendary-version (12:52:46) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version (12:52:47) INFO: [Legendary]: Legendary location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary (12:52:47) INFO: [Gog]: GOGDL location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl (12:52:47) INFO: [Gog]: GOGDL location: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl (12:52:47) INFO: [Backend]: MetaMask extension loaded (12:52:47) WARNING: [Backend]: Protocol already registered. (12:52:47) INFO: [Connection]: Connectivity: online (12:52:47) INFO: [Backend]: User Not Found, removing it from Store (12:52:47) INFO: [Backend]: Deleting abort controller for legendary-version (12:52:47) INFO: [Backend]: Creating abort controller for gogdl-version (12:52:47) INFO: [Gog]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --version (12:52:48) INFO: [Backend]: Deleting abort controller for gogdl-version (12:52:48) INFO: [Backend]: Auto Updater found version: 0.0.9 released on 2023-03-09T00:48:09.445Z with name 0.0.9 (12:52:48) INFO: [Backend]: Loading Screen Ready (12:52:48) INFO: [Backend]: Frontend Ready (12:52:52) INFO: [Backend]:

HyperPlay Version: 0.0.9 Legendary Version: 0.20.32 Dark Energy (hotfix #6) GOGdl Version: 0.6 OS: Microsoft Windows 11 Home KERNEL: 10.0.22621 ARCH: x64 CPU: Intel Core™ i7-8750H @2.2 RAM: Total: 31.88 GiB Available: 24.31 GiB GRAPHICS: GPU0: NVIDIA GeForce RTX 2070 with Max-Q Design VRAM: 8192MB DRIVER: 531.18

(12:52:53) INFO: [Backend]: Starting the Download Queue (12:56:50) INFO: [Backend]: Creating abort controller for legendary-login (12:56:50) INFO: [Legendary]: Logging in: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary auth --code (12:56:51) INFO: [Backend]: Deleting abort controller for legendary-login (12:56:51) INFO: [Frontend]: Refreshing Library (12:56:51) INFO: [Legendary]: Refreshing library... (12:56:51) INFO: [Legendary]: Refreshing Epic Games... (12:56:51) INFO: [Legendary]: Game list updated, got 2 games & DLCs (12:56:52) INFO: [Frontend]: No cache found, getting data from legendary... (12:56:52) INFO: [Legendary]: Refreshing library... (12:56:52) INFO: [Legendary]: Game list updated, got 2 games & DLCs (12:56:52) INFO: [Frontend]: Force Update (12:56:52) INFO: [Backend]: Creating abort controller for legendary-refresh (12:56:52) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party (12:56:54) INFO: [Backend]: Deleting abort controller for legendary-refresh (12:57:12) INFO: [Frontend]: Refreshing Library (12:57:12) INFO: [Legendary]: Refreshing library... (12:57:12) INFO: [Legendary]: Refreshing Epic Games... (12:57:12) INFO: [Legendary]: Game list updated, got 2 games & DLCs (12:57:13) INFO: [Backend]: Creating abort controller for legendary-refresh (12:57:13) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party (12:57:14) INFO: [Backend]: Deleting abort controller for legendary-refresh (12:58:06) INFO: [Legendary]: Getting more details with 'legendary info' (12:58:07) INFO: [Backend]: Creating abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:07) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary info 0850ff60ef984eeabc4914ab2e8b8852 --platform Windows --json (12:58:07) DEBUG: [Backend]: {"free":436603613184,"diskSize":511229050880,"message":"406.62 GiB / 476.12 GiB","validPath":true} (12:58:11) INFO: [Backend]: Deleting abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:11) DEBUG: [Backend]: {"free":436603420672,"diskSize":511229050880,"message":"406.62 GiB / 476.12 GiB","validPath":true} (12:58:32) DEBUG: [Backend]: {"free":954737004544,"diskSize":1000203087872,"message":"889.17 GiB / 931.51 GiB","validPath":true} (12:58:33) INFO: [DownloadManager]: Star Atlas was added to the download queue. (12:58:33) DEBUG: [Legendary]: Using cached install info (12:58:33) INFO: [Backend]: Preventing machine to sleep (12:58:33) DEBUG: [Legendary]: Using cached install info (12:58:33) INFO: [Backend]: Creating abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:33) INFO: [Legendary]: Installing 0850ff60ef984eeabc4914ab2e8b8852: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary install 0850ff60ef984eeabc4914ab2e8b8852 --platform Windows --base-path "D:\New folder" --skip-dlcs --skip-sdl -y (12:58:33) DEBUG: [Legendary]: Logging to file "C:\Users\George\AppData\Roaming\hyperplay\GamesConfig\0850ff60ef984eeabc4914ab2e8b8852.log" (12:58:35) INFO: [Backend]: Deleting abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:35) INFO: [Backend]: Creating abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:35) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary install 0850ff60ef984eeabc4914ab2e8b8852 --platform Windows --base-path "D:\New folder" --skip-dlcs --skip-sdl -y --max-shared-memory 5000 (12:58:35) DEBUG: [Legendary]: Logging to file "C:\Users\George\AppData\Roaming\hyperplay\GamesConfig\0850ff60ef984eeabc4914ab2e8b8852.log" (12:58:35) INFO: [Backend]: operation interrupted (12:58:37) INFO: [Backend]: Deleting abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (12:58:37) INFO: [Backend]: Adding shortcuts for Star Atlas (12:58:37) INFO: [DownloadManager]: Finished installing of 0850ff60ef984eeabc4914ab2e8b8852 (12:58:37) INFO: [DownloadManager]: 0850ff60ef984eeabc4914ab2e8b8852 added to download manager finished. (12:58:37) INFO: [DownloadManager]: 0850ff60ef984eeabc4914ab2e8b8852 removed from download manager. (12:58:37) INFO: [Frontend]: Refreshing Library (12:58:37) INFO: [Legendary]: Refreshing library... (12:58:37) INFO: [Legendary]: Game list updated, got 2 games & DLCs (12:58:37) INFO: [Backend]: operation interrupted (13:01:05) DEBUG: [Legendary]: Using cached install info (13:01:06) DEBUG: [Backend]: {"free":436600885248,"diskSize":511229050880,"message":"406.62 GiB / 476.12 GiB","validPath":true} (13:01:06) DEBUG: [Backend]: {"free":436600885248,"diskSize":511229050880,"message":"406.62 GiB / 476.12 GiB","validPath":true} (13:01:23) INFO: [ExtraGameInfo]: Getting ExtraGameInfo data for Star Atlas (13:01:23) INFO: [ExtraGameInfo]: Getting PCGamingWiki data for Star Atlas (13:01:23) INFO: [ExtraGameInfo]: Getting HowLongToBeat data for Star Atlas (13:01:23) DEBUG: [Legendary]: Using cached install info (13:01:23) DEBUG: [Legendary]: Using cached install info (13:01:23) DEBUG: [Legendary]: Using cached install info (13:01:23) DEBUG: [Legendary]: Using cached install info (13:01:35) DEBUG: [Legendary]: Using cached install info (13:01:36) DEBUG: [Backend]: {"free":436596936704,"diskSize":511229050880,"message":"406.61 GiB / 476.12 GiB","validPath":true} (13:01:36) DEBUG: [Backend]: {"free":436596936704,"diskSize":511229050880,"message":"406.61 GiB / 476.12 GiB","validPath":true} (13:01:39) INFO: [DownloadManager]: Star Atlas was added to the download queue. (13:01:39) DEBUG: [Legendary]: Using cached install info (13:01:39) DEBUG: [Legendary]: Using cached install info (13:01:39) INFO: [Backend]: Creating abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (13:01:39) INFO: [Legendary]: Installing 0850ff60ef984eeabc4914ab2e8b8852: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary install 0850ff60ef984eeabc4914ab2e8b8852 --platform Windows --base-path C:\Users\George\Games\HyperPlay --skip-dlcs --skip-sdl -y (13:01:39) DEBUG: [Legendary]: Logging to file "C:\Users\George\AppData\Roaming\hyperplay\GamesConfig\0850ff60ef984eeabc4914ab2e8b8852.log" (13:01:39) INFO: [Backend]: Preventing machine to sleep (13:01:39) DEBUG: [Legendary]: Using cached install info (13:01:39) DEBUG: [Legendary]: Using cached install info (13:01:41) INFO: [Backend]: Deleting abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (13:01:41) INFO: [Backend]: Creating abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (13:01:41) INFO: [Legendary]: Running command: C:\Users\George\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary install 0850ff60ef984eeabc4914ab2e8b8852 --platform Windows --base-path C:\Users\George\Games\HyperPlay --skip-dlcs --skip-sdl -y --max-shared-memory 5000 (13:01:41) DEBUG: [Legendary]: Logging to file "C:\Users\George\AppData\Roaming\hyperplay\GamesConfig\0850ff60ef984eeabc4914ab2e8b8852.log" (13:01:41) INFO: [Backend]: operation interrupted (13:01:43) INFO: [Backend]: Deleting abort controller for 0850ff60ef984eeabc4914ab2e8b8852 (13:01:43) INFO: [Backend]: Adding shortcuts for Star Atlas (13:01:43) INFO: [DownloadManager]: Finished installing of 0850ff60ef984eeabc4914ab2e8b8852 (13:01:43) INFO: [DownloadManager]: 0850ff60ef984eeabc4914ab2e8b8852 added to download manager finished. (13:01:43) INFO: [DownloadManager]: 0850ff60ef984eeabc4914ab2e8b8852 removed from download manager. (13:01:43) INFO: [Frontend]: Refreshing Library (13:01:43) INFO: [Legendary]: Refreshing library... (13:01:43) INFO: [Legendary]: Game list updated, got 2 games & DLCs (13:01:43) INFO: [Backend]: Stopping Power Saver Blocker (13:01:43) DEBUG: [Legendary]: Using cached install info (13:01:43) DEBUG: [Legendary]: Using cached install info (13:01:43) INFO: [Backend]: operation interrupted (13:01:43) DEBUG: [Legendary]: Using cached install info (13:01:43) DEBUG: [Legendary]: Using cached install info (13:11:22) INFO: [Connection]: Connectivity: offline (13:11:22) INFO: [Connection]: Connectivity: offline (13:11:22) INFO: [Connection]: Connectivity: offline (13:11:42) INFO: [Connection]: Connectivity: check-online (13:11:42) INFO: [Connection]: Pinging external endpoints (13:11:42) INFO: [Connection]: Connectivity: check-online (13:11:42) INFO: [Connection]: Pinging external endpoints (13:11:42) INFO: [Connection]: Connectivity: check-online (13:11:42) INFO: [Connection]: Pinging external endpoints (13:11:42) INFO: [Connection]: Connectivity: online (13:11:42) INFO: [Connection]: All ping requests failed: (13:11:42) INFO: [Connection]: AggregateError: All promises were rejected (13:11:43) INFO: [Connection]: Connectivity: online