HyperPlay-Gaming / hyperplay-desktop-client

The HyperPlay desktop app
https://hyperplay.xyz
GNU General Public License v3.0
77 stars 31 forks source link

No alert to user when extraction fails due to not enough space #613

Open nyghtstalker opened 1 year ago

nyghtstalker commented 1 year ago

Describe the bug

If an install fails due to lack of space there is no notification to the user and the download modal remains open (and will never close). It appears that it is still working from the user's perspective. The only way to know what is going on is to check the logs.

There should be some sort of notification to the user of the issue and the modal should not remain open.

NOTE: Upon relaunch the download modal appears again even though there is nothing downloading.

Add logs


(11:58:17) INFO:    [HyperPlay]:        Getting install info for MEGAWEAPON

(11:59:22) INFO:    [ProtocolHandler]:  received 'hyperplay://launch/hyperplay/0xb09dd4b6889867acf4a98b062c94d854995b0fd4f3f97599302b1e96cba2ef3b'

(11:59:22) INFO:    [ProtocolHandler]:  "Phantom Galaxies" not installed.

(11:59:23) INFO:    [HyperPlay]:        Getting install info for Phantom Galaxies

(11:59:27) INFO:    [HyperPlay]:        Getting install info for Phantom Galaxies

(11:59:27) INFO:    [DownloadManager]:  Phantom Galaxies  was added to the download queue.

(11:59:27) INFO:    [HyperPlay]:        Installing Phantom Galaxies to C:\Users\Joe\Games\HyperPlay...

(11:59:27) INFO:    [Backend]:          Preventing machine to sleep

(11:59:28) INFO:    [HyperPlay]:        Updating platform info with access code gated platform info in HyperPlay Game Manager

(11:59:28) INFO:    [HyperPlay]:        Downloading zip file to directory C:\Users\Joe\AppData\Roaming\hyperplay\.temp\0xb09dd4b6889867acf4a98b062c94d854995b0fd4f3f97599302b1e96cba2ef3b filename phantom-galaxies-0.5.5%2520windows.zip

(11:59:28) INFO:    [HyperPlay]:        Downloading from https://gateway.valist.io/ipfs/bafybeibjusk3aglelluhbbtmmm7stupnm2qkwpy53s6i2wfkhg452ofdyi/windows_amd64/phantom-galaxies-0.5.5%20windows.zip?token=XgCauS5hg3HbdRnzurn-rncdMfIj3XFtsYpwuzRTqR0&expires=1698778767

(11:59:28) INFO:    [Backend]:          Creating abort controller for 0xb09dd4b6889867acf4a98b062c94d854995b0fd4f3f97599302b1e96cba2ef3b

(11:59:28) INFO:    [Backend]:          Started downloading phantom-galaxies-0.5.5 windows.zip

(11:59:29) INFO:    [HyperPlay]:        Downloaded: 62.62 MB / 23.15 GB  @56.06 MB/s (0.26%)

(11:59:30) INFO:    [HyperPlay]:        Downloaded: 132.77 MB / 23.15 GB  @68.57 MB/s (0.56%)

(12:08:34) INFO:    [HyperPlay]:        Downloaded: 23.15 GB / 23.15 GB  @68.98 KB/s (100.00%)

(12:08:35) INFO:    [Backend]:          Download completed phantom-galaxies-0.5.5 windows.zip

(12:08:35) INFO:    [HyperPlay]:        Extracting C:\Users\Joe\AppData\Roaming\hyperplay\.temp\0xb09dd4b6889867acf4a98b062c94d854995b0fd4f3f97599302b1e96cba2ef3b\phantom-galaxies-0.5.5%2520windows.zip to C:\Users\Joe\Games\HyperPlay\blowfishstudios\phantomgalaxies

(12:09:47) ERROR:   [Backend]:          'Uncaught Exception occured!': Error: ENOSPC: no space left on device, write

(12:19:47) INFO:    [Backend]:          Creating abort controller for legendary-version

(12:19:47) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary --version

(12:19:47) INFO:    [Backend]:          Creating abort controller for gogdl-version

(12:19:47) INFO:    [Gog]:              Running command: C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\Joe\AppData\Roaming\hyperplay\gog_store\auth.json --version

(12:19:47) INFO:    [Backend]:          Creating abort controller for 98bc04bc842e4906993fd6d6644ffb8d

(12:19:47) INFO:    [Legendary]:        Checking if EOS Overlay is enabled: XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info

(12:19:47) INFO:    [Backend]:          Deleting abort controller for gogdl-version

(12:19:47) INFO:    [Backend]:          Deleting abort controller for legendary-version

(12:19:48) INFO:    [Backend]:          Aborting 98bc04bc842e4906993fd6d6644ffb8d

(12:19:48) INFO:    [Backend]:          Aborted 98bc04bc842e4906993fd6d6644ffb8d

(12:19:48) INFO:    [Legendary]:        Abort command "XDG_CONFIG_HOME=C:\Users\Joe\AppData\Roaming\hyperplay\legendaryConfig C:\Users\Joe\AppData\Local\Programs\hyperplay\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info"

Steps to reproduce

  1. Make sure the drive has insufficient storage space for installation AND FOR EXTRACTION
  2. Start install
  3. Observe that the modal stays open and no notification

Expected behavior

The user should be informed of the problem and the modal should close

Screenshots

image

image

image

image

image

hyperplay Version

Latest Stable

System Information

Additional information

No response

nyghtstalker commented 4 months ago

This should be looked into more to add a more user friendly experience.