HyperSMP / EggHuntPlugin

Minecraft plugin adding the ability to track and steal the Dragon Egg from other players
6 stars 3 forks source link

Buffs/Bonuses for Holding the Egg #7

Open ShaB4NG opened 1 year ago

ShaB4NG commented 1 year ago

(I have also posted this in the discussion section on the Spigot page but I wanted to post here too)

Hey man I'm super interested in this concept. I'm gonna plug it into my server, but I have a suggestion/request for you.

Do you think you could please add a feature where if a player has the egg in their inventory/in their hand, they get buffs or potion effects such as Strength, Swiftness, Night vision, Regen, etc? Or maybe it gives the same bonus as a golden apple/god apple, but it lasts until the egg leaves their inventory? I would love it if the egg holder gets some sort of bonus as it adds more incentive to go after it. Not to mention it would make the player who holds it more like a boss, who can replace the ender dragon for those who weren't around to defeat it.

Thanks for posting this plugin, I'll still be using it if you don't see this but I hope you do!

J0hnL0cke commented 1 year ago

Thanks, I'm glad you like the plugin! 😄

GitHub is the best place to send bug reports and enhancement requests since I'll definitely get a notification when they're created.

I've considered adding effects for holding or owning the egg for a while, but I'm still trying to figure out exactly how to implement that in the plugin.

I've been thinking about using teams or the scoreboard to let commands select the egg owner, like /tell @a[team=eggOwner] hi, but that feels a bit too bulky for marking only one entity at a time. The advantage would be less work for me figuring out how to constantly apply affects to a player and how to make that easily configurable, as well as letting server owners do more with commands, like teleporting the owner, messaging them, or making their arrows explosive.

However, in looking this up, I've just realized entity tags exist for this exact purpose, and don't require the setup that comes with teams or a scoreboard. I think I'll prioritize tagging the egg owner, since it should be very easy to set up. Then server owners can set up their own command blocks and select the owner of the dragon egg by doing /effect give @a[tag=eggOwner] strength. I'll make the specific tag name customizable via config.

I'm still planning to have the plugin able to apply effects to players, so this can be done with command blocks disabled and won't require loading the chunks containing command blocks, but seeing as that's nowhere near ready, hopefully tagging will be a good workaround, even if it is a bit more setup for server owners.

Thanks for the suggestion, hope this will work for you!

ShaB4NG commented 1 year ago

Hey man thanks for the reply, I love your plugin. Well I can certainly give the command block feature a go, but I'll sit tight for when it's inplamented into the plugin. That is gonna be sick I'm looking forward to the next update of your plugin ❤️

On Sun, 16 Jul 2023, 1:17 pm John Locke, @.***> wrote:

Thanks, I'm glad you like the plugin! 😄

GitHub is the best place to send bug reports and enhancement requests since I'll definitely get a notification when they're created.

I've considered adding effects for holding or owning the egg for a while, but I'm still trying to figure out exactly how to implement that in the plugin.

I've been thinking about using teams or the scoreboard to let commands select the egg owner, like /tell @a[team=eggOwner] hi, but that feels a bit too bulky for marking only one entity at a time. The advantage would be less work for me figuring out how to constantly apply affects to a player and how to make that easily configurable, as well as letting server owners do more with commands, like teleporting the owner, messaging them, or making their arrows explosive.

However, in looking this up, I've just realized entity tags exist for this exact purpose, and don't require the setup that comes with teams or a scoreboard. I think I'll prioritize tagging the egg owner, since it should be very easy to set up. Then server owners can set up their own command blocks and select the owner of the dragon egg by doing /effect give @a[tag=eggOwner] strength. I'll make the specific tag name customizable via config.

I'm still planning to have the plugin able to apply effects to players, so this can be done with command blocks disabled and won't require loading the chunks containing command blocks, but seeing as that's nowhere near ready, hopefully tagging will be a good workaround, even if it is a bit more setup for server owners.

Thanks for the suggestion, hope this will work for you!

— Reply to this email directly, view it on GitHub https://github.com/HyperSMP/EggHuntPlugin/issues/7#issuecomment-1636939495, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7QL6PO7S5LYV775KBHGLWDXQM6KJANCNFSM6AAAAAA2KTF3KU . You are receiving this because you authored the thread.Message ID: @.***>