search

Hyperfoil / Horreum

Benchmark results repository service
https://horreum.hyperfoil.io/
Apache License 2.0
38 stars 31 forks source link

Importing a PROTECTED Schema object cannot be viewed in the UI. #1653

Open whitingjr opened 6 months ago

whitingjr commented 6 months ago

Describe the bug

A Horreum Schema imported with PROTECTED visibility cannot be viewed in the UI.

The sequence of HTTP requests to Horreum is the issue. The request to load the Schema by the id occurs before the authentication request to Keycloak. This causes the first request not to include sending the cooking AUTH_SESSION_ID. Which obviously will fail to load a PROTECTED object.

To Reproduce

Create a Schema with PROTECTED visibility. Export Schema to disk Delete Schema using the UI Import same Schema from local disk. In the UI navigate away from Schema. In the UI navigate back to Schema to see the list. Click the imported schema. The page does not load the definition of the Schema.

Version

0.12.2

Java

17

Browser

Firefox 124

johnaohara commented 6 months ago

On Hold due to https://github.com/Hyperfoil/Horreum/discussions/1603

lampajr commented 6 months ago

On Hold due to #1603

IIUC this issue is not only affecting Schema entities but most of the owned entities, like Test. And it looks more an UI issue, thus I think there is no relation/block with the ongoing "Schema removal" discussion.

johnaohara commented 6 months ago

This issue relates specifically to Schemas, if there is a more general issue, that needs to be tracked

From the private discussions that have been happening, I am under the impression that Schemas and LabelValues will be re-written in "one hit" as they are interrelated. The reason given is so we do not have an intermediate state, where we are having write code that will be removed/re-written.

If we are continuing to fix the current bugs, we are duplicating effort. That is why I put it on hold.

@stalep thoughts?

lampajr commented 6 months ago

This issue relates specifically to Schemas, if there is a more general issue, that needs to be tracked

yeah, makes sense! I will create a more general one.

If we are continuing to fix the current bugs, we are duplicating effort.

I definitely agree on this :rocket: