search

Hyperfoil / Horreum

Benchmark results repository service
https://horreum.hyperfoil.io/
Apache License 2.0
38 stars 31 forks source link

Review usage of `prettier` dependency #1990

Open johnaohara opened 1 month ago

johnaohara commented 1 month ago

Describe the bug

Horreum-web module imports the prettier dependency, which is referenced in the prettier-format script

Review usage of the dependency to determine if it is used, whether is should be used, removed or replaced

shivam-sharma7 commented 1 month ago

@johnaohara If you want to proper utilize this dep.. then pre-commit hooks can help us in order to format horreum-web module codebase.

johnaohara commented 1 month ago

Hi @shivam-sharma7, hope you are well! thanks for the input. This issue was opened because we are not using this dependency atm. We have just re-introduced code formatting on the java part of the project with an auto-formatter that is tied to the build lifecycle: https://github.com/Hyperfoil/Horreum/commit/285ec5168fb115185260e689c1abd20634727863

I opened this issue with the intention of reviewing whether we can use the new formatter with the .TS code as well.

We have had problems in the past with git hooks working transparently across all envs (win,linux, macos) and was hoping we could tie it into the maven build lifecycle

shivam-sharma7 commented 1 month ago

Hi @shivam-sharma7, hope you are well!

@johnaohara I'm good, what about you?

I opened this issue with the intention of reviewing whether we can use the new formatter with the .TS code as well.

If you can format TS code via new formatter then prettier no longer needed

We have had problems in the past with git hooks working transparently across all envs (win,linux, macos) and was hoping we could tie it into the maven build lifecycle

Yeah, I remember