Hyperfoil / Horreum

Benchmark results repository service
https://horreum.hyperfoil.io/
Apache License 2.0
39 stars 31 forks source link

Downgrade Keycloak to 23.0.7 #2025

Closed johnaohara closed 1 month ago

johnaohara commented 1 month ago

Keycloak version was incompatible with services running SSO

Fixes Issue

Fixes: #2061

Changes proposed

Check List (Check all the applicable boxes)

johnaohara commented 1 month ago

@lampajr it's a mess after we upgraded quarkus :(

johnaohara commented 1 month ago

either we need to remove the dependency on quarkus-keycloak-admin-resteasy-client or only use Quarkus LTS releases

lampajr commented 1 month ago

it's a mess after we upgraded quarkus :(

+1

either we need to remove the dependency on quarkus-keycloak-admin-resteasy-client

I was trying this locally, but even if that works for the test I am not fully sure we won't introduce any bug by forcing quarkus-keycloak-admin-resteasy-client to use an older version of keycloak

only use Quarkus LTS releases

I think this will be something we should start considering..

lampajr commented 1 month ago

either we need to remove the dependency on quarkus-keycloak-admin-resteasy-client or only use Quarkus LTS releases

Both options are not so straightforward.. :sweat:

johnaohara commented 1 month ago

@lampajr i saw this error when re-using a prod backup that had been loaded in dev mode by current main or 0.15 branch. When I tested with a fresh backup it worked without error.

I think the with the current main branch, upgrading to keycloak 0.25.x will have modified the database tables, which are incompatible with 0.23.x, so downgrading keycloak on an already migrated database will break auth.

We need to be able to chose the keycloak version to maintain compatibility with production versions