unreadable log after using secret states (the ones prefixed by underscore)

[vitorz]

After the introduction of secret states for holding some passwords in a qdup file, most of the log messages are unreadable and huge. It's just a log issue as all the rest looks working to me. The log messages look in this way: ***************e********************************************************************************r**************************************

[vitorz]

this happens if the secret is loaded as empty string.

[johnaohara]

@vitorz thanks for getting to the bottom of this, I will re-open as this is an issue that renders the entire log unreadable

[willr3]

It sounds like there are two issues:

1. The SecretFilter should not add an empty string as a secret.
2. Secret values that contain other secret values need to be checked first to prevent exposing part of the longer secret.

anything we think I missed?

[vitorz]

Hi, thanks for fixing. Nothing is missing for me.

[willr3]

closing as we merged the fix for the secretsfilter