HyperionGray / trio-chrome-devtools-protocol

Trio driver for Chrome DevTools Protocol (CDP)
MIT License
60 stars 17 forks source link

Extended more abstract Functions and Classes using API #11

Open auphofBSF opened 4 years ago

auphofBSF commented 4 years ago

@mehaase I have been extensively using the #6 api and will soon move to the #9. I have a number of functional classes providing and implementing more abstract functions, such as keyboard, mouse actions , and more utility functions for finding and focusing, reading or manipulating elements. This results that the end application is very clean and reasonably elegant

By enlarge I have been incorporating functionality from the likes of https://github.com/miyakogi/pyppeteer an unoffical https://github.com/puppeteer/puppeteer port.

Some key benefits are

1) the async functions of https://github.com/python-trio/trio provided through https://github.com/HyperionGray/trio-chrome-devtools-protocol. 2) keep the application to pure CDP with no javascript injection or manipulation 3) Light weight

I feel many of these classes I have created are worth putting up on Github but under what structure, Do we add on to trio-chrome-devtools-protocol or create another module trio-puppeteer There are many pro's and con's but I have only implemented a small but to me very useful subset of puppeteer

Interested in perspectives from @mehaase or other users or contributers who may have ideas and relevant comments to structure, naming

mehaase commented 4 years ago

Hey @auphofBSF, that sounds like a great idea! It makes more sense to publish your library in a new repo, because (a) I want to keep this repo focused on one task and (b) I may not have much time to maintain this repo this year, so getting it stable is a pressing goal for me.

If you name your new library after Puppeteer, I think users will expect you to implement the entire Puppeteer API. That's a lot of work to replicate, plus you'll be on the hook to follow all of the changes that Google's team makes upstream. Best of luck!