[FIX] connection close and fixes pytest tests

HyperionGray / trio-chrome-devtools-protocol

Trio driver for Chrome DevTools Protocol (CDP)

MIT License

62 stars 18 forks source link

[FIX] connection close and fixes pytest tests #7

Closed auphofBSF closed 4 years ago

auphofBSF commented 4 years ago

If I terminate The connection _reader_task when the WebSocket is closed then the examples execute and the pytest tests pass.

I have marked a TODO: that if the connection closure is ABNORMAL we should raise the exception , but I am not sure if this is valid. Particularly why the abnormal closure is being signaled in the examples\get_title.py.

I don't think this PR fully address's the situation but it does make all existing tests and examples work

mehaase commented 4 years ago

Thank you for submitting this. Unfortunately this PR contains commits for both #1 and #5, so I cannot merge it as is.

I will be working on #5 today, however, and hope to have a fix completed soon.

mehaase commented 4 years ago

This is fixed in ee7598fc332621c6865f8d76c37d1fb35d112ccc.