search

HyperiumClient / Hyperium-Kotlin

Hyperium Client rewritten in Kotlin with good coding standards.
GNU Lesser General Public License v3.0
5 stars 3 forks source link

Travis CI #19

Open FalseHonesty opened 5 years ago

FalseHonesty commented 5 years ago

This issue was mentioned in #18. I would like for CI to be setup for this project. Currently, the CI should not deploy anything, rather, it should just confirm that the project is building and that the gradle check task successfully passes. This will provide contributors with the piece of mind that their code is correct, and will provide maintainers with proof that all new code works.

RDIL commented 5 years ago

Correct me if I’m wrong, but the install command is gradle assemble right?

FalseHonesty commented 5 years ago

Install command? Do you mean build? The full build command is ./gradlew build

FalseHonesty commented 5 years ago

Actually, Travis itself should not run any checks other than project building (and eventually possible deployment). Rather, it should defer to Danger to check for these issues. There are multiple plugins that I believe would be nice for us to use, such as KOTLIN_DETEKT, JUNIT, COMMIT_LINT, TODOIST, and possibly MENTION. In addition, there are probably some detections we should roll into the project ourselves, such as making sure tests are added for large changes, and more.