search

HyperledgerHandsOn / trade-finance-logistics

Trade Finance and Logistics based on Letter of Credit and Proof of Shipment
Apache License 2.0
178 stars 1.5k forks source link

fix error launching trade.sh in dev mode #43

Closed woodyjon closed 5 years ago

woodyjon commented 5 years ago

When launching trade.sh in dev mode, following errors prevent proper launch of the containers:

(I made the PR on the branch release-1.2 instead of master as that branch is further)

woodyjon commented 5 years ago

For info, I was using fabric 1.4. I did not realize that your code was tested on 1.1. (maybe would be good to specify in the book the version of fabric to checkout)

VRamakrishna commented 5 years ago

Yeah, we missed it during editing, but noticed the omission immediately after publication. It's on the errata page for the book on PacktPub (you have access to that, right?) Also, if you check the READMEs on this project (in the network folder), we've stated the version constraint.

VRamakrishna commented 5 years ago

@woodyjon I finally got around to looking at your changes and testing them. The only change which I see as necessary is the one made to devmode/configtx.yaml (which is similar to the change made in the parent folder.)

The trade.sh command is meant to be run in the network folder, so having a .env in there will suffice. You are, of course, free to run the command from the subfolder if you wish, but there's no need to add a copy of the .env file to the repository; you can just make a copy on your local system before a run.

I also don't see the need for a change in devmode/docker-compose-e2e-template.yaml. My test ran fine with the earlier file. I suspect you had an older docker container lying around that caused a port conflict; hence, you needed to remove the port number. Try running it again after cleaning up all the extant containers (using docker kill followed by docker rm.)

Please test out my above suggestions and make appropriate changes. I'll approve the PR then.

woodyjon commented 5 years ago

@VRamakrishna sorry I forgot to reply to your previous comment. Thank you for all your work!!