HyperledgerHandsOn / trade-finance-logistics

Trade Finance and Logistics based on Letter of Credit and Proof of Shipment
Apache License 2.0
174 stars 1.49k forks source link

generateCert function's sed command issue for osx. #62

Closed bosoa closed 5 years ago

bosoa commented 5 years ago

ISSUE: When running ./trade.sh generate -c tradechannel command for testing, I found sed command has issue on osx.

SOLVE: change [sed -i] with [sed -i ""].

REASON: Unlike Ubuntu, OS X requires the extension to be explicitly specified. The workaround is to set an empty string: $ sed -i '' 's/megatron/pony/g' /path/to/file.txt (ref: https://github.com/lmquang/til/issues/18)

VRamakrishna commented 5 years ago

Fixed with https://github.com/HyperledgerHandsOn/trade-finance-logistics/commit/da0d715c9c22b989a0e5da20da496068652b92f7