search

Hyperline / hyperline

✨ Status line plugin for Hyper ✨
MIT License
621 stars 121 forks source link

Modules can't be found in Hyper 1.4.8 #152

Closed tjwelde closed 6 years ago

tjwelde commented 6 years ago

On start of Hyper, a notification pops up, that react couldn't be found. I cloned this plugin locally and introduced react, but now it says, that hyper/component is missing.

I guess hyper doesn't provide these packages anymore?

https://github.com/Hyperline/hyperline/blob/3346645271179e2b6eae00e587a9883cdf4ea52d/webpack.config.js#L13

scerelli commented 6 years ago

I get this too

tjwelde commented 6 years ago

Ok. Apparently hyper hijacks the module loading system: https://github.com/zeit/hyper/blob/1.4.8/lib/utils/plugins.js#L21. The error thrown here seems to be a bug of hyper.

abhishekchotaliya commented 6 years ago

I got the same problem, but moving the hyperline configuration below plugins solved the issue.

plugins: ['hyperpower', 'hyperline'],

hyperline: { plugins: [ "ip", "cpu", "spotify" ] },

R0uter commented 6 years ago

@abhishekchotaliya

moving the hyperline configuration below plugins

It worked! thx. But some how, hyperline do not read config hyperline: { plugins: [ "ip", "cpu", "spotify" ] }, :(

tjwelde commented 6 years ago

So since we have hyper2 stable now, I would say this issue is obsolete. Let's just make this plugin work for hyper2 now. Ongoing issue about that: https://github.com/Hyperline/hyperline/issues/150