(Try to) Fix HyperLine on Hyper 2

Hyperline / hyperline

✨ Status line plugin for Hyper ✨

MIT License

619 stars 120 forks source link

(Try to) Fix HyperLine on Hyper 2 #161

Open NTag opened 6 years ago

NTag commented 6 years ago

Try to make HyperLine work on Hyper 2 (cf. https://github.com/Hyperline/hyperline/issues/159 and https://github.com/Hyperline/hyperline/issues/160):

React is now bundled as a dependency, as it should be;
Using hyper/component is deprecated, use React.Component instead;
Remove prop-types from devDependencies (already present in dependencies).

Works with Hyper 2.1.0-canary.2 on macOS 10.13.

lexdevelop commented 6 years ago

Just try it with Hyper 2.1.0-canary.2 on Ubuntu 18.04, not working :(

liloow commented 6 years ago

Used your pull request as boilerplate and added the code I mentioned in #163

Hyper@latest (canary) Arch

Never had any issues screencap

jpmckearin commented 6 years ago

@liloow can you upload that to a fork?

liloow commented 6 years ago

@jpmckearin Sorry I was on vacation last week : fork Tested on Arch

EDIT: Added custom dist (sorry for my oversight :grin:) and custom branch with that ugly global.onload properly coded and a couple other details (this means core file have been modified hence the new branch)

lexdevelop commented 5 years ago

Tested again Hyper 2.1.0-canary.2 on Ubuntu 18.04 with https://github.com/liloow/hyperline and works perfect, thank you.

charles4221 commented 5 years ago

Any ideas on when this will be merged in? Currently, Hyperline is unusable on Hyper 2.1.0 on MacOS because of these deprecations.

Sly777 commented 5 years ago

Is there any plan to merge this?

talentlessguy commented 4 years ago

Had to delete hyperline bcoz of annoying deprecation messages. Please merge it someone!