Open carl0shd opened 3 years ago
It looks like this is caused by the network
and spotify
plugins, which are both enabled by default — disabling both, by adding the following to my config and performing a full reload, means hyperline works again for me:
config: {
hyperline: {
plugins: ["hostname","ip","memory", "battery", "cpu"]
},
}
The network
plugin is failing as the systeminformation
module it depends on is calling execSync
to determine the interface name, which is blocked, so receives the following error:
Calling execSync from renderer is disabled
That means result
is undefined, and an an Uncaught TypeError occurs: Cannot read property 'toString' of undefined
hyperline is currently set to ^3.4.1
(here) of the systeminformation
package
https://www.npmjs.com/package/systeminformation/v/3.54.0 https://github.com/sebhildebrandt/systeminformation/blob/v3.52.1/lib/network.js#L57-L58
Similarly for the spotify
plugin — it depends on an applescript module which is calling spawn
which is similarly blocked:
Calling spawn from renderer is disabled
Presumably something changed in the latest release which blocks these?
If I enable the network plugin I get a console error every 1.5s which matches the interval set here: https://github.com/Hyperline/hyperline/blob/master/src/lib/plugins/network.js#L47-L54
Should the call to getSpeed()
be happening outside this, so that it's not called within the render function? Perhaps related to this change? https://github.com/vercel/hyper/pull/5803
@mattheath your trick with the version 3.1.4 doesn't work. Meaning the plugin is still crashing.
@mattheath I can confirm your suggestion works, although at the moment only the Spotify plugin seems to be crashing hyperline for Hyper v. 3.1.4
Hi guys, i am using Hyper 3.1.2 but when i install Hyperline, never shows.