Hyperline / hyperline

✨ Status line plugin for Hyper ✨
MIT License
616 stars 120 forks source link

Display Git information #62

Closed Connorelsea closed 6 years ago

Connorelsea commented 7 years ago

My idea would be to separate related sections of git info into separate hyperline plugins.

I'd be interesting in implementing this and submitting a PR if that is okay with the maintainers.

We could possibly use this library.

timneutkens commented 7 years ago

@Connorelsea Fine idea. Go for it :shipit:

amandeepmittal commented 7 years ago

@Connorelsea +1

NickTikhonov commented 7 years ago

@Connorelsea great idea - providing a way of moving git information away from the prompt and into the status bar could be useful for a lot of people!

Anahkiasen commented 7 years ago

I tried to take a shot at it but I bumped into two issues:

  1. I'm not entirely sure how to get the cwd from one of the plugin's perspective, looked in the component's context and all but I can't find where that info would be
  2. Currently as the components are not tied to the cwd, they do not re-render when the user changes folder

Now both of those are most likely doable but, I didn't have enough time to properly look further, if someone else wants to take a look.

timneutkens commented 7 years ago

@Anahkiasen https://github.com/henrikdahl/hyper-statusline has git info. Take a look at that source 😄, if you're going to add it. Please do it in the develop branch.

Anahkiasen commented 7 years ago

Yes that's the plugin I looked at (because originally I thought I could use both but they overlap each other) but as far as I can see it handles this in an entirely different way from the way Hyperline is architectured :/

timneutkens commented 7 years ago

@Anahkiasen me, @NickTikhonov and @henrikdahl have plans to combine the two status lines. Just haven't had time to implement it all 😄 I'll have a look when I get to it :)

henrikruscon commented 7 years ago

I've lacked time as well. I'll also look into it when I find time ✌️

sangdth commented 7 years ago

Please, this feature is awesome.

corbin-r commented 7 years ago

@sangdth this feature is being worked on by @henrikdahl and myself. Henrik has this feature already in a statusline plugin of his own so it's mainly the process of getting it ported over to Hyperline.

sangdth commented 7 years ago

Thanks for your fast response @basedjux, I came here after installed the statusline plugin but it was covered by hyperline. Looking forward. Thanks for all your contribution.

corbin-r commented 7 years ago

Yeah no problem 😄

And yeah you can't have them both running, it has to be one or the other for right now.

FranklinYu commented 5 years ago

Why this was closed? Is this feature implemented?