Closed raphaelweis closed 5 months ago
We have amended the previous commit to satisfy the review.
Thank you for your updates @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.
SCENARIO
should be followed by the title of a feature or a fix being scenarized. I suggest you to rephrase the whole commit title it in something like PROCESS: Scenario steps related to glose blocks should be reusable.
. See that as a nice opportunity for your entire team to test "interactive rebase". Of course I can help you if needed.Thank you for your contribution @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.
Is it your last version?
I thought it was done but it seems that, without your fix, your test that should pass fails. Is this right?
Thank you for your contribution @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.
Is it your last version?
I thought it was done but it seems that, without your fix, your test that should pass fails. Is this right?
I believe the implementation of the fix to be correct, but it broke multiple CSS selectors in the test implementations. I have looked at it a bit but so far no luck fixing the failing tests. I'll have another look at it this weekend or next week.
Once we get all the tests to pass again it should be good to merge.
Thank you for your answer @raphaelweis. I've found what was the problem with the tests.
On blank gloses, the testing bot – which is far faster than a normal user – "clicks" on your new block place holder before it is replaced by "<TEXT>".
The tests were fixed with 40c68972f27f127fcd5db4c7ca7ddd03efbad777.
Your branch is now merged. Well done @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1!
This adds the cases mentioned in #161 to the feature.