Hypertopic / HyperGlosae

A Nelsonian hypertext infrastructure for digital humanities
11 stars 22 forks source link

feat: added 2 scenarios related to #161 #162

Closed raphaelweis closed 5 months ago

raphaelweis commented 6 months ago

This adds the cases mentioned in #161 to the feature.

raphaelweis commented 6 months ago

We have amended the previous commit to satisfy the review.

benel commented 5 months ago

Thank you for your updates @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.

benel commented 5 months ago

Thank you for your contribution @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.

Is it your last version?

I thought it was done but it seems that, without your fix, your test that should pass fails. Is this right?

raphaelweis commented 5 months ago

Thank you for your contribution @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1.

Is it your last version?

I thought it was done but it seems that, without your fix, your test that should pass fails. Is this right?

I believe the implementation of the fix to be correct, but it broke multiple CSS selectors in the test implementations. I have looked at it a bit but so far no luck fixing the failing tests. I'll have another look at it this weekend or next week.

Once we get all the tests to pass again it should be good to merge.

benel commented 5 months ago

Thank you for your answer @raphaelweis. I've found what was the problem with the tests.

On blank gloses, the testing bot – which is far faster than a normal user – "clicks" on your new block place holder before it is replaced by "<TEXT>".

The tests were fixed with 40c68972f27f127fcd5db4c7ca7ddd03efbad777.

Your branch is now merged. Well done @raphaelweis, @Barnabepetit, @louisduhalberruer, @nitram35, @petitfa1!